[ 
https://issues.apache.org/jira/browse/GROOVY-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113619#comment-18113619
 ] 

ASF GitHub Bot commented on GROOVY-12395:
-----------------------------------------

codecov-commenter commented on PR #2918:
URL: https://github.com/apache/groovy/pull/2918#issuecomment-5611644912

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2918?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :x: Patch coverage is `81.81818%` with `4 lines` in your changes missing 
coverage. Please review.
   :white_check_mark: Project coverage is 71.1978%. Comparing base 
([`63a8329`](https://app.codecov.io/gh/apache/groovy/commit/63a832981c3c05832b0dab7f1e17cfb89fba90d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`8b1cbc6`](https://app.codecov.io/gh/apache/groovy/commit/8b1cbc68a2adcd80c00297c796d04ae6f6ec6dac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 6 commits behind head on master.
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2918?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...g/codehaus/groovy/vmplugin/v8/IndyCatchCompat.java](https://app.codecov.io/gh/apache/groovy/pull/2918?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv8%2FIndyCatchCompat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlDYXRjaENvbXBhdC5qYXZh)
 | 81.8182% | [4 Missing :warning: 
](https://app.codecov.io/gh/apache/groovy/pull/2918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/2918/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/2918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #2918        +/-   ##
   ==================================================
   + Coverage     71.1948%   71.1978%   +0.0030%     
   - Complexity      37694      37705        +11     
   ==================================================
     Files            1584       1584                
     Lines          136413     136434        +21     
     Branches        25343      25348         +5     
   ==================================================
   + Hits            97119      97138        +19     
   - Misses          30537      30538         +1     
   - Partials         8757       8758         +1     
   ```
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2918?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[...g/codehaus/groovy/vmplugin/v8/IndyCatchCompat.java](https://app.codecov.io/gh/apache/groovy/pull/2918?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv8%2FIndyCatchCompat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlDYXRjaENvbXBhdC5qYXZh)
 | `81.8182% <81.8182%> (-9.8485%)` | :arrow_down: |
   
   ... and [8 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/2918/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> IndyCatchCompat: obtain its handles without a by-name lookup so R8 needs no 
> keep rule
> -------------------------------------------------------------------------------------
>
>                 Key: GROOVY-12395
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12395
>             Project: Groovy
>          Issue Type: Improvement
>            Reporter: Paul King
>            Assignee: Paul King
>            Priority: Major
>             Fix For: 6.0.0-RC-2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to