[
https://issues.apache.org/jira/browse/GROOVY-12429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118998#comment-18118998
]
ASF GitHub Bot commented on GROOVY-12429:
-----------------------------------------
codecov-commenter commented on PR #2948:
URL: https://github.com/apache/groovy/pull/2948#issuecomment-5825658659
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2948?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 71.7454%. Comparing base
([`40e59c5`](https://app.codecov.io/gh/apache/groovy/commit/40e59c5c116e53e96013a06a97c09923b7752969?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`1cdf9f5`](https://app.codecov.io/gh/apache/groovy/commit/1cdf9f5e5e6f3e2d9a2533807ebfa4045d134e60?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2948?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2948 +/- ##
==================================================
+ Coverage 71.6067% 71.7454% +0.1387%
- Complexity 38062 38118 +56
==================================================
Files 1588 1588
Lines 137078 137114 +36
Branches 25507 25514 +7
==================================================
+ Hits 98157 98373 +216
+ Misses 30014 29818 -196
- Partials 8907 8923 +16
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2948?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...e/src/main/groovy/groovy/console/ui/Console.groovy](https://app.codecov.io/gh/apache/groovy/pull/2948?src=pr&el=tree&filepath=subprojects%2Fgroovy-console%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fconsole%2Fui%2FConsole.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnNvbGUvc3JjL21haW4vZ3Jvb3Z5L2dyb292eS9jb25zb2xlL3VpL0NvbnNvbGUuZ3Jvb3Z5)
| `17.8475% <100.0000%> (+17.8475%)` | :arrow_up: |
... and [13 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2948/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> GroovyConsole error link does not place the caret on the reported column
> ------------------------------------------------------------------------
>
> Key: GROOVY-12429
> URL: https://issues.apache.org/jira/browse/GROOVY-12429
> Project: Groovy
> Issue Type: Bug
> Reporter: Daniel Sun
> Priority: Major
>
> h2. Problem
> A compilation error in GroovyConsole prints a location such as {{line: 1,
> column: 9}}. Activating that link selects the whole line and leaves the caret
> after the last character. The status bar shows the end of the line, not the
> column named in the message, so the link does not show where the error is.
> On a later line the selection also starts at the newline that ends the
> previous line.
> h2. Steps to reproduce
> Run this script in GroovyConsole. The opening quote is not closed.
> {noformat}
> println '123
> {noformat}
> In the output pane, activate {{line: 1, column: 9}}.
> h2. Actual result
> The whole line is selected. The script is 12 characters long, the caret is
> left after the last character, and the status bar reads {{1:13}}.
> h2. Expected result
> The caret is on the opening quote, that character is selected, and the status
> bar reads {{1:9}}.
> When an error spans more than one character, the span is selected and the
> caret stays on the column named in the message. The status bar uses the same
> character columns as that message.
> h2. Other cases covered by the same defect
> * A location on a later line starts at the first character of that line.
> * A stack-trace link that names only a line still selects that whole line,
> from its first character. The status bar shows column 1 of that line.
> * A column past the end of the line stays on that line.
> * Activating the link from the keyboard moves the caret to the same place as
> a mouse click.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
