[
https://issues.apache.org/jira/browse/GROOVY-12433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18119572#comment-18119572
]
ASF GitHub Bot commented on GROOVY-12433:
-----------------------------------------
codeconsole opened a new pull request, #2949:
URL: https://github.com/apache/groovy/pull/2949
https://issues.apache.org/jira/browse/GROOVY-12433
Moves groovy-yaml, groovy-toml and groovy-csv from Jackson 2 to Jackson 3
(`tools.jackson` 3.1.6, the version Spring Boot 4.2 manages). None of them
exposes a Jackson type, so callers need no changes.
- Mappers are built with `configureForJackson2()` so parsing and
serialization behave as before. The CSV mapper also enables
`SORT_PROPERTIES_ALPHABETICALLY`, which Jackson 2's `CsvMapper` turned on
itself: plain classes keep alphabetical columns and records keep declaration
order, as the user guide documents.
- `jackson-datatype-jsr310` is dropped; java.time support is built into
Jackson 3 databind.
- `XmlParser.parseAs`/`parseTextAs` use Jackson 3 when present and fall back
to Jackson 2. A failed conversion now carries Jackson's exception; from dynamic
Groovy it used to surface as an `InvocationTargetException` with no message.
The cached mapper is now published after its method, so a concurrent first call
can't see a null method.
- The SnakeYAML alias recipe in the YAML guide now declares
`org.yaml:snakeyaml`, since Jackson 3's YAML backend uses SnakeYAML Engine.
- `tools.jackson` and `snakeyaml-engine` are signed with keys the dependency
verification already trusts; two scoped trust entries are added.
- The JSON and XML guide recipes for using Jackson directly now use the
Jackson 3 artifacts.
> Move groovy-yaml, groovy-toml and groovy-csv to Jackson 3
> ---------------------------------------------------------
>
> Key: GROOVY-12433
> URL: https://issues.apache.org/jira/browse/GROOVY-12433
> Project: Groovy
> Issue Type: Improvement
> Components: groovy-csv, groovy-toml, groovy-yaml, XML Processing
> Reporter: Scott Murphy Heiberg
> Priority: Major
> Fix For: 7.0.0-alpha-1
>
>
> groovy-yaml, groovy-toml and groovy-csv are built on Jackson 2
> ({{com.fasterxml.jackson}} 2.22.x). Spring Boot 4 uses Jackson 3
> ({{tools.jackson}}) by default, so an application on Spring Boot 4 that uses
> one of these modules carries both major versions and has to manage the
> Jackson 2 one itself. Jackson 2 and 3 use different packages and coordinates,
> so having Jackson 3 on the classpath does nothing for these modules.
> None of the three modules exposes a Jackson type in its public API, so they
> can move to Jackson 3 without source changes for callers.
> Proposal:
> * Depend on {{tools.jackson}} 3.1.6, the version Spring Boot 4.2 manages.
> {{jackson-datatype-jsr310}} is no longer needed; java.time support is built
> into Jackson 3 databind.
> * Build every mapper with {{configureForJackson2()}} so behaviour is
> unchanged: properties in declaration order, unknown properties rejected,
> nulls for primitives and trailing tokens accepted. The CSV mapper also keeps
> {{SORT_PROPERTIES_ALPHABETICALLY}}, which Jackson 2's {{CsvMapper}} enabled
> itself and the user guide documents.
> * {{XmlParser.parseAs}} and {{parseTextAs}} load jackson-databind
> reflectively; use Jackson 3 when present and fall back to Jackson 2.
> * Jackson 3's YAML backend uses SnakeYAML Engine rather than SnakeYAML, so
> the SnakeYAML alias recipe from GROOVY-12358 needs {{org.yaml:snakeyaml}}
> declared explicitly, as the user guide already anticipates.
> Jackson 3 still uses {{com.fasterxml.jackson.annotation}}, so
> {{@JsonProperty}}, {{@JsonFormat}} and the other annotations in user code
> keep working.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
