[
https://issues.apache.org/jira/browse/GROOVY-12455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18129040#comment-18129040
]
ASF GitHub Bot commented on GROOVY-12455:
-----------------------------------------
codecov-commenter commented on PR #2994:
URL: https://github.com/apache/groovy/pull/2994#issuecomment-6287037530
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2994?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `63.63636%` with `8 lines` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 72.4325%. Comparing base
([`dcf5462`](https://app.codecov.io/gh/apache/groovy/commit/dcf5462908edae076de1fd6642400cd07087ae0b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`7c5f957`](https://app.codecov.io/gh/apache/groovy/commit/7c5f957f258f865d730dab281bb728b237de8c89?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2994?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2994?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh)
| 63.6364% | [3 Missing and 5 partials :warning:
](https://app.codecov.io/gh/apache/groovy/pull/2994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2994 +/- ##
==================================================
+ Coverage 72.4261% 72.4325% +0.0063%
- Complexity 40612 40620 +8
==================================================
Files 1643 1643
Lines 142664 142686 +22
Branches 26792 26798 +6
==================================================
+ Hits 103326 103351 +25
Misses 29832 29832
+ Partials 9506 9503 -3
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2994?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2994?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh)
| `87.0788% <63.6364%> (-0.1205%)` | :arrow_down: |
... and [6 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2994/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Regression: NegativeArraySizeException during Groovy compilation
> ----------------------------------------------------------------
>
> Key: GROOVY-12455
> URL: https://issues.apache.org/jira/browse/GROOVY-12455
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 5.0.6, 5.0.8
> Reporter: Björn Kautler
> Assignee: Paul King
> Priority: Major
>
> If you check out this branch:
> [https://github.com/Vampire/spock/tree/groovy-compiler-bug]
> and run {{{}./gradlew -Dvariant=5.0 :spock-specs:compileTestGroovy{}}}, you
> get the following exception.
> With the 4.0 variant and thus 4.0.32 the compilation works just fine.
> {code:java}
> > Unrecoverable compilation error: startup failed:
> General error during instruction selection: ASM reporting processing error
> for org.spockframework.runtime.model.SpecInfoHierarchySpec#setupSpec with
> signature setupSpec():java.lang.Object in SpecInfoHierarchySpec.groovy:20.
> [...]\spock-specs\src\test\groovy\org\spockframework\runtime\model\SpecInfoHierarchySpec.groovy
>
> groovy.lang.GroovyRuntimeException: ASM reporting processing error for
> org.spockframework.runtime.model.SpecInfoHierarchySpec#setupSpec with
> signature setupSpec():java.lang.Object in SpecInfoHierarchySpec.groovy:20.
> [...]\spock-specs\src\test\groovy\org\spockframework\runtime\model\SpecInfoHierarchySpec.groovy
> at
> org.codehaus.groovy.classgen.AsmClassGenerator.visitConstructorOrMethod(AsmClassGenerator.java:642)
> at
> org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitMethod(ClassCodeVisitorSupport.java:110)
> at
> org.codehaus.groovy.classgen.AsmClassGenerator.visitMethod(AsmClassGenerator.java:769)
> at org.codehaus.groovy.ast.ClassNode.visitMethods(ClassNode.java:1338)
> at
> org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1331)
> at
> org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitClass(ClassCodeVisitorSupport.java:52)
> at
> org.codehaus.groovy.classgen.AsmClassGenerator.visitClass(AsmClassGenerator.java:379)
> at
> org.codehaus.groovy.control.CompilationUnit$3.call(CompilationUnit.java:780)
> at
> org.codehaus.groovy.control.CompilationUnit$IPrimaryClassNodeOperation.doPhaseOperation(CompilationUnit.java:922)
> at
> org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:668)
> at
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:642)
> at
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:623)
> at
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:287)
> at
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:69)
> at
> org.gradle.api.internal.tasks.compile.DaemonSideCompiler.execute(DaemonSideCompiler.java:45)
> at
> org.gradle.api.internal.tasks.compile.DaemonSideCompiler.execute(DaemonSideCompiler.java:28)
> at
> org.gradle.api.internal.tasks.compile.daemon.CompilerWorkAction.execute(CompilerWorkAction.java:52)
> at
> org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:68)
> at
> org.gradle.workers.internal.AbstractClassLoaderWorker$1.create(AbstractClassLoaderWorker.java:54)
> at
> org.gradle.workers.internal.AbstractClassLoaderWorker$1.create(AbstractClassLoaderWorker.java:48)
> at
> org.gradle.internal.classloader.ClassLoaderUtils.executeInClassloader(ClassLoaderUtils.java:102)
> at
> org.gradle.workers.internal.AbstractClassLoaderWorker.executeInClassLoader(AbstractClassLoaderWorker.java:48)
> at
> org.gradle.workers.internal.IsolatedClassloaderWorker.run(IsolatedClassloaderWorker.java:49)
> at
> org.gradle.workers.internal.IsolatedClassloaderWorker.run(IsolatedClassloaderWorker.java:30)
> at
> org.gradle.workers.internal.WorkerDaemonServer.run(WorkerDaemonServer.java:108)
> at
> org.gradle.workers.internal.WorkerDaemonServer.run(WorkerDaemonServer.java:77)
> at
> org.gradle.process.internal.worker.request.WorkerAction.lambda$run$1(WorkerAction.java:150)
> at
> org.gradle.process.internal.worker.child.WorkerLogEventListener.withWorkerLoggingProtocol(WorkerLogEventListener.java:41)
> at
> org.gradle.process.internal.worker.request.WorkerAction.lambda$run$2(WorkerAction.java:150)
> at
> org.gradle.internal.operations.CurrentBuildOperationRef.with(CurrentBuildOperationRef.java:84)
> at
> org.gradle.process.internal.worker.request.WorkerAction.run(WorkerAction.java:142)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.gradle.internal.dispatch.MethodInvocation.invokeOn(MethodInvocation.java:77)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:28)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:19)
> at
> org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:182)
> at
> org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:164)
> at
> org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:414)
> at
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
> at
> org.gradle.internal.concurrent.AbstractManagedExecutor$1.run(AbstractManagedExecutor.java:47)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: java.lang.NegativeArraySizeException: -10
> at groovyjarjarasm.asm.Frame.merge(Frame.java:1233)
> at
> groovyjarjarasm.asm.MethodWriter.computeAllFrames(MethodWriter.java:1612)
> at groovyjarjarasm.asm.MethodWriter.visitMaxs(MethodWriter.java:1548)
> at
> org.codehaus.groovy.classgen.AsmClassGenerator.visitConstructorOrMethod(AsmClassGenerator.java:624)
> ... 45 more
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
