daniellansun commented on PR #2976: URL: https://github.com/apache/groovy/pull/2976#issuecomment-6397238616
Thanks Paul — good catch on the unguarded `installLanguageHost` path. Head `acc5ce549e` catches `LinkageError` while constructing the host (same missing-jar shape as the editor filter and groovysh). The console stays open, `languageHost` stays null, we log one warning, and that window’s Compiler Assistance item is disabled. The saved preference is left alone so a later launch can try again if the jar is restored. Other failures still propagate. The opener is a package-scoped `@Internal` Closure seam (production uses `ConsoleLanguageHost.attach`) so the test can throw `NoClassDefFoundError` the same way the filter test does. Also moved the orphaned host Javadoc onto `compileAndDiagnostics`, and marked the `@ASTTest` per-thread helpers `@Internal` as you suggested. Happy to adjust further if you’d rather the menu stay checked-but-disabled (preference still on) instead of unchecked, or if you want the View toggle to persist the preference only after a successful attach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
