[
https://issues.apache.org/jira/browse/GROOVY-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18132047#comment-18132047
]
ASF GitHub Bot commented on GROOVY-12519:
-----------------------------------------
codecov-commenter commented on PR #3045:
URL: https://github.com/apache/groovy/pull/3045#issuecomment-6407779906
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3045?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `85.71429%` with `2 lines` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 73.6102%. Comparing base
([`e301e08`](https://app.codecov.io/gh/apache/groovy/commit/e301e08c4de31eb61b0805e45c7a99b879f165f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`ffae307`](https://app.codecov.io/gh/apache/groovy/commit/ffae307f5fcd8c21168b1779bc82c98330411e4a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3045?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/3045?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=)
| 84.6154% | [0 Missing and 2 partials :warning:
](https://app.codecov.io/gh/apache/groovy/pull/3045?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/3045?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #3045 +/- ##
==================================================
+ Coverage 73.6073% 73.6102% +0.0029%
- Complexity 42312 42314 +2
==================================================
Files 1657 1657
Lines 145620 145632 +12
Branches 27466 27474 +8
==================================================
+ Hits 107187 107200 +13
Misses 28469 28469
+ Partials 9964 9963 -1
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3045?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3045?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh)
| `87.4971% <100.0000%> (+0.0261%)` | :arrow_up: |
|
[src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/3045?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=)
| `79.1111% <84.6154%> (+0.0166%)` | :arrow_up: |
... and [15 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/3045/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> super.sm() and super.sp fail for static members of the superclass (dynamic
> Groovy, and in a closure under SC)
> -------------------------------------------------------------------------------------------------------------
>
> Key: GROOVY-12519
> URL: https://issues.apache.org/jira/browse/GROOVY-12519
> Project: Groovy
> Issue Type: Bug
> Components: groovy-runtime, Static compilation
> Affects Versions: 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> A static method or static property of the superclass reached through
> {{super}} fails in dynamic Groovy:
> {code:groovy}
> class Base {
> static String sm() { 'sm:base' }
> static String sp = 'sp:base'
> }
> class Dyn extends Base {
> static String sm() { 'sm:dyn' }
> static String sp = 'sp:dyn'
> String m() { super.sm() }
> String p() { super.sp }
> }
> new Dyn().m() // MissingMethodException: No signature of method: sm for
> class: Base
> new Dyn().p() // MissingPropertyException: No such property: sp for class: Dyn
> {code}
> The same happens inside a closure. javac accepts the equivalent Java and
> returns {{sm:base}} and {{sp:base}}. Under {{@CompileStatic}} both work in
> the class body and {{super.sp}} works in a closure, but {{super.sm()}} in a
> closure fails with {{IncompatibleClassChangeError: Expecting non-static
> method 'java.lang.String Base.sm()'}}, because the {{super$}} helper method
> calls the static method with {{invokespecial}}.
> In dynamic Groovy the super call is resolved through the {{super$}} helper
> methods of the class, which are not generated for static methods. Seen in
> 4.0.33, 5.0.8 and master.
> Expected: {{super.sm()}} and {{super.sp}} call the superclass's static method
> and read its static property, in every mode, in the class body and in
> closures and lambdas.
> PR: https://github.com/apache/groovy/pull/3045 (split out of
> https://github.com/apache/groovy/pull/3044)
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
