[
https://issues.apache.org/jira/browse/GROOVY-12520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18132052#comment-18132052
]
ASF GitHub Bot commented on GROOVY-12520:
-----------------------------------------
codecov-commenter commented on PR #3046:
URL: https://github.com/apache/groovy/pull/3046#issuecomment-6407873576
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3046?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `83.33333%` with `1 line` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 73.6156%. Comparing base
([`e301e08`](https://app.codecov.io/gh/apache/groovy/commit/e301e08c4de31eb61b0805e45c7a99b879f165f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`15cfcd7`](https://app.codecov.io/gh/apache/groovy/commit/15cfcd7452a211969fc054a60d216aa80822f6cd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3046?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/3046?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=)
| 83.3333% | [0 Missing and 1 partial :warning:
](https://app.codecov.io/gh/apache/groovy/pull/3046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/3046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #3046 +/- ##
==================================================
+ Coverage 73.6073% 73.6156% +0.0083%
- Complexity 42312 42318 +6
==================================================
Files 1657 1657
Lines 145620 145624 +4
Branches 27466 27467 +1
==================================================
+ Hits 107187 107202 +15
+ Misses 28469 28461 -8
+ Partials 9964 9961 -3
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3046?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/3046?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=)
| `79.1411% <83.3333%> (+0.0466%)` | :arrow_up: |
... and [13 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/3046/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> super.x calls getX() instead of isX() when the class overrides isX()
> --------------------------------------------------------------------
>
> Key: GROOVY-12520
> URL: https://issues.apache.org/jira/browse/GROOVY-12520
> Project: Groovy
> Issue Type: Bug
> Components: groovy-runtime
> Affects Versions: 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> When a class declares both {{isX()}} and {{getX()}}, Groovy reads the
> property {{x}} through {{isX()}} (GROOVY-10133), also through {{super}}. If
> the subclass overrides {{isX()}} or declares a {{boolean x}} property,
> dynamic Groovy and {{@TypeChecked}} read {{super.x}} through the superclass's
> {{getX()}} instead:
> {code:groovy}
> class C {
> boolean isX() { true }
> boolean getX() { false }
> }
> class D extends C {
> boolean isX() { false }
> boolean test() { super.x }
> }
> class E extends C {
> boolean x
> boolean test() { super.x }
> }
> assert new D().test() // fails: false
> assert new E().test() // fails: false
> {code}
> {{@CompileStatic}} returns {{true}} for both, and so does dynamic Groovy
> 4.0.33. 5.0.0, 5.0.8, 6.0.0 and master return {{false}}.
> For {{super}}, the getter of an overridden method is the MOP method
> {{super$2$isX}}, and the check that keeps {{isX()}} over {{getX()}} only
> accepts a method whose name starts with "is", so {{getX()}} replaces it.
> Expected: {{super.x}} calls {{C.isX()}} in every mode.
> PR: https://github.com/apache/groovy/pull/3046
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
