[
https://issues.apache.org/jira/browse/GROOVY-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18133640#comment-18133640
]
ASF GitHub Bot commented on GROOVY-12533:
-----------------------------------------
codecov-commenter commented on PR #3065:
URL: https://github.com/apache/groovy/pull/3065#issuecomment-6473240522
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3065?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `89.58333%` with `5 lines` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 73.6115%. Comparing base
([`cfd9b2f`](https://app.codecov.io/gh/apache/groovy/commit/cfd9b2f0222a8e1a74473f7c5b2cb45b5bdd3b5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`9527450`](https://app.codecov.io/gh/apache/groovy/commit/95274501e983c2f6d9dd9d9e0359cb4d0f187dec?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3065?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...sc/transformers/PropertyExpressionTransformer.java](https://app.codecov.io/gh/apache/groovy/pull/3065?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fsc%2Ftransformers%2FPropertyExpressionTransformer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zYy90cmFuc2Zvcm1lcnMvUHJvcGVydHlFeHByZXNzaW9uVHJhbnNmb3JtZXIuamF2YQ==)
| 50.0000% | [1 Missing and 3 partials :warning:
](https://app.codecov.io/gh/apache/groovy/pull/3065?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...rg/codehaus/groovy/classgen/AsmClassGenerator.java](https://app.codecov.io/gh/apache/groovy/pull/3065?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FAsmClassGenerator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL0FzbUNsYXNzR2VuZXJhdG9yLmphdmE=)
| 96.7742% | [0 Missing and 1 partial :warning:
](https://app.codecov.io/gh/apache/groovy/pull/3065?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/3065?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #3065 +/- ##
==================================================
+ Coverage 73.6047% 73.6115% +0.0068%
- Complexity 42348 42367 +19
==================================================
Files 1657 1657
Lines 145708 145753 +45
Branches 27498 27509 +11
==================================================
+ Hits 107248 107291 +43
+ Misses 28479 28476 -3
- Partials 9981 9986 +5
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3065?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[.../sc/transformers/StaticCompilationTransformer.java](https://app.codecov.io/gh/apache/groovy/pull/3065?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fsc%2Ftransformers%2FStaticCompilationTransformer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zYy90cmFuc2Zvcm1lcnMvU3RhdGljQ29tcGlsYXRpb25UcmFuc2Zvcm1lci5qYXZh)
| `98.7500% <100.0000%> (+0.1585%)` | :arrow_up: |
|
[...rg/codehaus/groovy/classgen/AsmClassGenerator.java](https://app.codecov.io/gh/apache/groovy/pull/3065?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FAsmClassGenerator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL0FzbUNsYXNzR2VuZXJhdG9yLmphdmE=)
| `85.8484% <96.7742%> (+0.2183%)` | :arrow_up: |
|
[...sc/transformers/PropertyExpressionTransformer.java](https://app.codecov.io/gh/apache/groovy/pull/3065?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fsc%2Ftransformers%2FPropertyExpressionTransformer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zYy90cmFuc2Zvcm1lcnMvUHJvcGVydHlFeHByZXNzaW9uVHJhbnNmb3JtZXIuamF2YQ==)
| `89.1892% <50.0000%> (-10.8108%)` | :arrow_down: |
... and [12 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/3065/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> this.@name and super.@name fail in a closure of a nested subclass for a
> private field of the outer class
> --------------------------------------------------------------------------------------------------------
>
> Key: GROOVY-12533
> URL: https://issues.apache.org/jira/browse/GROOVY-12533
> Project: Groovy
> Issue Type: Bug
> Components: groovy-runtime, Static compilation
> Affects Versions: 6.0.0
> Reporter: Scott Murphy Heiberg
> Assignee: Daniel Sun
> Priority: Major
>
> In a static nested class that extends its outer class, {{this.@f}} and
> {{super.@f}} read a private field {{f}} of the outer class. Inside a closure
> or lambda of the same method, both fail at run time:
> {code:groovy}
> class Outer {
> private String f = 'outer'
> static class Sub extends Outer {
> def direct() { [this.@f, super.@f] }
> def viaClosure() { [{ -> this.@f }(), { -> super.@f }()] }
> }
> }
> def sub = new Outer.Sub()
> assert sub.direct() == ['outer', 'outer']
> sub.viaClosure() // MissingFieldException: No such field: f for class:
> Outer$Sub
> {code}
> {{super.@f}} in the closure fails the same way, with "No such field: f for
> class: Outer". {{@TypeChecked}} behaves like dynamic Groovy, and both fail
> the same way in a lambda, and for {{Sub.this.@f}} in an anonymous inner class
> created in {{Sub}}. Under {{@CompileStatic}}, {{super.@f}} in a closure or
> lambda throws the same {{MissingFieldException}}. {{this.@f}} fails there
> with {{VerifyError}}, inside and outside a closure, until the change for
> GROOVY-12511, which makes it read the field. Seen in 5.0.8, 6.0.0 and master;
> in 4.0.33 the access failed outside a closure too.
> Expected: the closure reads the field, as its enclosing method does.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
