[
https://issues.apache.org/jira/browse/GROOVY-12435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18133709#comment-18133709
] ASF GitHub Bot commented on GROOVY-12435: ----------------------------------------- codecov-commenter commented on PR #3070: URL: https://github.com/apache/groovy/pull/3070#issuecomment-6475983638 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/3070?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `79.06977%` with `18 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 73.6086%. Comparing base ([`cfd9b2f`](https://app.codecov.io/gh/apache/groovy/commit/cfd9b2f0222a8e1a74473f7c5b2cb45b5bdd3b5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7dfa2c`](https://app.codecov.io/gh/apache/groovy/commit/a7dfa2c1578b9fc7427c4403f5d0468f334f3608?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3070?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...g/apache/groovy/parser/antlr4/GroovyLangLexer.java](https://app.codecov.io/gh/apache/groovy/pull/3070?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FGroovyLangLexer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0dyb292eUxhbmdMZXhlci5qYXZh) | 78.8732% | [11 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/3070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ovy/parser/antlr4/util/PositionConfigureUtils.java](https://app.codecov.io/gh/apache/groovy/pull/3070?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2Futil%2FPositionConfigureUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L3V0aWwvUG9zaXRpb25Db25maWd1cmVVdGlscy5qYXZh) | 80.0000% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/3070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/3070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #3070 +/- ## ================================================== + Coverage 73.6047% 73.6086% +0.0039% - Complexity 42348 42359 +11 ================================================== Files 1657 1657 Lines 145708 145794 +86 Branches 27498 27516 +18 ================================================== + Hits 107248 107317 +69 - Misses 28479 28494 +15 - Partials 9981 9983 +2 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3070?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ovy/parser/antlr4/util/PositionConfigureUtils.java](https://app.codecov.io/gh/apache/groovy/pull/3070?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2Futil%2FPositionConfigureUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L3V0aWwvUG9zaXRpb25Db25maWd1cmVVdGlscy5qYXZh) | `93.8462% <80.0000%> (-4.1539%)` | :arrow_down: | | [...g/apache/groovy/parser/antlr4/GroovyLangLexer.java](https://app.codecov.io/gh/apache/groovy/pull/3070?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FGroovyLangLexer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0dyb292eUxhbmdMZXhlci5qYXZh) | `85.8491% <78.8732%> (-14.1509%)` | :arrow_down: | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/3070/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > carriage-return only line ending does not increment line number > --------------------------------------------------------------- > > Key: GROOVY-12435 > URL: https://issues.apache.org/jira/browse/GROOVY-12435 > Project: Groovy > Issue Type: Bug > Components: parser-antlr4 > Affects Versions: 3.0.25, 4.0.33, 5.1.3, 6.0.0 > Reporter: Eric Milles > Assignee: Daniel Sun > Priority: Major > Attachments: LineEndings.groovy, image-2026-09-30-09-41-06-973.png > > > [^LineEndings.groovy]I had a source file with mixed line endings that caused > a lot of trouble with the editor. I traced this back to the parser's handling > of line endings. It seems when a line ending is just a carriage-return (\r) > the line number is not incremented. > !image-2026-09-30-09-41-06-973.png! > In this example, the import and script statement have lines 2 and 6 > respectively. They should be at lines 3 and 7 as can be seen by the line > numbering in the editor's gutter. The antlr2 parser handled this case > properly. -- This message was sent by Atlassian Jira (v10.3.26#10030026)
