[
https://issues.apache.org/jira/browse/GROOVY-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18133713#comment-18133713
] ASF GitHub Bot commented on GROOVY-12526: ----------------------------------------- codecov-commenter commented on PR #3071: URL: https://github.com/apache/groovy/pull/3071#issuecomment-6476266578 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/3071?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.66667%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 73.6054%. Comparing base ([`cfd9b2f`](https://app.codecov.io/gh/apache/groovy/commit/cfd9b2f0222a8e1a74473f7c5b2cb45b5bdd3b5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6142d2c`](https://app.codecov.io/gh/apache/groovy/commit/6142d2cde9aa0ba13c63fb6083831f735132b8a0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3071?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...va/org/codehaus/groovy/control/ResolveVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3071?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fcontrol%2FResolveVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NvbnRyb2wvUmVzb2x2ZVZpc2l0b3IuamF2YQ==) | 71.4286% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/3071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3071?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh) | 50.0000% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/3071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/3071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #3071 +/- ## ================================================== + Coverage 73.6047% 73.6054% +0.0007% - Complexity 42348 42359 +11 ================================================== Files 1657 1657 Lines 145708 145723 +15 Branches 27498 27507 +9 ================================================== + Hits 107248 107260 +12 + Misses 28479 28475 -4 - Partials 9981 9988 +7 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3071?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3071?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh) | `87.4508% <50.0000%> (-0.0203%)` | :arrow_down: | | [...va/org/codehaus/groovy/control/ResolveVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3071?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fcontrol%2FResolveVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NvbnRyb2wvUmVzb2x2ZVZpc2l0b3IuamF2YQ==) | `90.3712% <71.4286%> (-0.5486%)` | :arrow_down: | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/3071/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > I.super.m() is not rejected when I is not a direct superinterface > ----------------------------------------------------------------- > > Key: GROOVY-12526 > URL: https://issues.apache.org/jira/browse/GROOVY-12526 > Project: Groovy > Issue Type: Bug > Components: Compiler > Affects Versions: 6.0.0 > Reporter: Scott Murphy Heiberg > Assignee: Daniel Sun > Priority: Major > > javac rejects {{I.super.m()}} unless {{I}} is a direct superinterface of the > current class or interface ("not an enclosing class: I"). Groovy does not > reject it, and dynamic Groovy runs something else: > {code:groovy} > interface J { default String m() { 'J' } } > interface I extends J { > default String m() { 'I' } > default String n() { I.super.m() } > } > class C implements I { } > assert new C().n() == 'I' // I's own m(), not J.m() > {code} > {code:groovy} > interface Outer { > default String m() { 'outer' } > class Inner { > String test() { Outer.super.m() } // Inner does not implement Outer > } > } > new Outer.Inner().test() // GroovyBugError: BUG! UNCAUGHT EXCEPTION: caller > class must be a subclass below the method: Outer.m()String/invokeSpecial, > from class Outer$Inner > {code} > Under {{@TypeChecked}} and {{@CompileStatic}} both are rejected, but with "No > such property: super for Class or static property for class: I" (and "...: > Outer"). Seen in 5.0.8, 6.0.0 and master. In 4.0.33 the first example > returned 'I' in every mode, and the second failed with > {{MissingPropertyException}}. > Expected: a compile error in every mode, as javac gives. -- This message was sent by Atlassian Jira (v10.3.26#10030026)
