[
https://issues.apache.org/jira/browse/GROOVY-11744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18133835#comment-18133835
] ASF GitHub Bot commented on GROOVY-11744: ----------------------------------------- codecov-commenter commented on PR #3073: URL: https://github.com/apache/groovy/pull/3073#issuecomment-6480360513 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/3073?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.66667%` with `9 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 73.6117%. Comparing base ([`cfd9b2f`](https://app.codecov.io/gh/apache/groovy/commit/cfd9b2f0222a8e1a74473f7c5b2cb45b5bdd3b5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9fa4ed0`](https://app.codecov.io/gh/apache/groovy/commit/9fa4ed0279d3e0aade801cf63ea87987181ca083?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 7 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3073?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...us/groovy/classgen/asm/BinaryExpressionHelper.java](https://app.codecov.io/gh/apache/groovy/pull/3073?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2FBinaryExpressionHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9CaW5hcnlFeHByZXNzaW9uSGVscGVyLmphdmE=) | 57.1429% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/3073?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/codehaus/groovy/control/PlaceholderVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3073?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fcontrol%2FPlaceholderVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NvbnRyb2wvUGxhY2Vob2xkZXJWaXNpdG9yLmphdmE=) | 62.5000% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/3073?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/3073?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #3073 +/- ## ================================================== + Coverage 73.6047% 73.6117% +0.0070% - Complexity 42348 42377 +29 ================================================== Files 1657 1657 Lines 145708 145754 +46 Branches 27498 27513 +15 ================================================== + Hits 107248 107292 +44 - Misses 28479 28482 +3 + Partials 9981 9980 -1 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3073?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...rg/codehaus/groovy/classgen/AsmClassGenerator.java](https://app.codecov.io/gh/apache/groovy/pull/3073?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FAsmClassGenerator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL0FzbUNsYXNzR2VuZXJhdG9yLmphdmE=) | `85.6618% <100.0000%> (+0.0317%)` | :arrow_up: | | [...org/codehaus/groovy/classgen/asm/CompileStack.java](https://app.codecov.io/gh/apache/groovy/pull/3073?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2FCompileStack.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9Db21waWxlU3RhY2suamF2YQ==) | `84.1176% <100.0000%> (-0.5882%)` | :arrow_down: | | [...rg/codehaus/groovy/control/PlaceholderVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3073?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fcontrol%2FPlaceholderVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NvbnRyb2wvUGxhY2Vob2xkZXJWaXNpdG9yLmphdmE=) | `89.4737% <62.5000%> (-7.1930%)` | :arrow_down: | | [...us/groovy/classgen/asm/BinaryExpressionHelper.java](https://app.codecov.io/gh/apache/groovy/pull/3073?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2FBinaryExpressionHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9CaW5hcnlFeHByZXNzaW9uSGVscGVyLmphdmE=) | `88.4514% <57.1429%> (-0.5860%)` | :arrow_down: | ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/3073/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Unnamed variables are actually used > ----------------------------------- > > Key: GROOVY-11744 > URL: https://issues.apache.org/jira/browse/GROOVY-11744 > Project: Groovy > Issue Type: Bug > Reporter: Georgii Ustinov > Assignee: Daniel Sun > Priority: Major > > I am currently implementing Groovy 5 support inside Intellij IDEA and > encountered the following behaviour. Consider the following code: > {code:java} > package org.example.demo > static void main(String[] args) { > def _ = 1 > def (_, _) = [2, 3] > println _ > } {code} > I expected that it will print 1, since variable declaration contains only > unnamed variables. > Actually it prints 3. The same behaviour can be encountered here: > {code:java} > def _ = 1 > def x = (_, _) -> { > println(_) > } > x(2, 3){code} > I beileve this is a bug. -- This message was sent by Atlassian Jira (v10.3.26#10030026)
