[
https://issues.apache.org/jira/browse/GROOVY-12565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18134449#comment-18134449
]
ASF GitHub Bot commented on GROOVY-12565:
-----------------------------------------
codecov-commenter commented on PR #3094:
URL: https://github.com/apache/groovy/pull/3094#issuecomment-6507838636
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3094?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 73.6773%. Comparing base
([`5b077f9`](https://app.codecov.io/gh/apache/groovy/commit/5b077f9dcf610898e3415f1f1cebbaab8eecab61?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`ff60e9a`](https://app.codecov.io/gh/apache/groovy/commit/ff60e9a0644931aaa5152e78a83036884d3c08fe?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/3094?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #3094 +/- ##
==================================================
+ Coverage 73.6711% 73.6773% +0.0062%
- Complexity 42584 42589 +5
==================================================
Files 1678 1678
Lines 146907 146911 +4
Branches 27790 27791 +1
==================================================
+ Hits 108228 108240 +12
+ Misses 28528 28522 -6
+ Partials 10151 10149 -2
```
[see 15 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/3094/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> groovy-lsp LspFixture throws ConcurrentModificationException while the
> compile thread publishes
> -----------------------------------------------------------------------------------------------
>
> Key: GROOVY-12565
> URL: https://issues.apache.org/jira/browse/GROOVY-12565
> Project: Groovy
> Issue Type: Test
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> {{LspFixture}} records the client notifications in a
> {{Collections.synchronizedList}} and plain lists. The server's debounced
> compile thread adds to them while a test iterates them, e.g.
> {{publishedParams*.uri}}, and the iterator of a synchronized list is not
> synchronized.
> {{GroovyLanguageServerTest.publishDiagnosticsIncludeVersionAndClearRemovedUris}}
> failed on CI with a ConcurrentModificationException when the background
> compile published during that read, after the publishing itself was
> serialized.
> Fix: record into {{CopyOnWriteArrayList}}s, whose iterators read a snapshot.
> PR: https://github.com/apache/groovy/pull/3094
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
