[
https://issues.apache.org/jira/browse/GROOVY-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18134531#comment-18134531
]
ASF GitHub Bot commented on GROOVY-12581:
-----------------------------------------
codeconsole opened a new pull request, #3107:
URL: https://github.com/apache/groovy/pull/3107
`{ log << new StringBuilder('a').with { append('b') }.toString() }` in a
`@CompileStatic` class now works, as it did in 4.0. Before, it failed with
`IncompatibleClassChangeError: Class java.lang.StringBuilder does not implement
the requested interface groovy.lang.GroovyObject` for any delegate that is not
a Groovy object.
The type checker records when an implicit-this call in a closure goes to the
delegate, and the static invocation writer then replaces the receiver with
`this.delegate`, but kept the call adapter chosen for a call on `this`. The
instance initializer blocks of a `@CompileStatic` class are type checked, but
their calls get no method targets, so the call was made dynamically with
`ScriptBytecodeAdapter.invokeMethodOnCurrent`, which takes a `GroovyObject`.
Once the receiver has been replaced, the writer now makes such a call with the
`invokeMethod` adapter, as for any other receiver. A `toString()` call inside
such a closure goes to the closure itself under static compilation until
GROOVY-12576 (#3102) is merged.
Tests: `ClosuresSTCTest.testClosureDelegateInInstanceInitializer` (also run
statically compiled by `ClosuresStaticCompileTest`), which fails without the
change. The `groovy`, `gls`, `bugs` and `org.codehaus.groovy` packages pass
(15,512 tests), apart from three `@Grab` tests
(`CoercionSTCTest.testCoerceToFunctionalInterface14`, also run by
`CoercionStaticCompileTests`, and
`GenericsSTCTest.testSelfReferentialTypeParameter5`) whose download failed
while other builds ran; they pass when rerun. The Checkstyle and CodeNarc gates
pass.
A regression in 5.0.0: 4.0.33 is correct, 5.0.8 and 6.0.0 are not.
> SC: a delegating closure in an instance initializer block fails for a
> delegate that is not a Groovy object
> ----------------------------------------------------------------------------------------------------------
>
> Key: GROOVY-12581
> URL: https://issues.apache.org/jira/browse/GROOVY-12581
> Project: Groovy
> Issue Type: Bug
> Components: Static compilation
> Affects Versions: 5.0.8, 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> {code:groovy}
> @groovy.transform.CompileStatic
> class C {
> List<String> log = [];
> { log << new StringBuilder('a').with { append('b'); toString() } }
> }
> new C() // IncompatibleClassChangeError: Class java.lang.StringBuilder does
> not implement the requested interface groovy.lang.GroovyObject
> {code}
> The type checker records when an implicit-this call in a closure goes to the
> delegate, and the static invocation writer then replaces the receiver with
> {{this.delegate}}, but keeps the call adapter chosen for a call on {{this}}.
> The instance initializer blocks of a {{@CompileStatic}} class are type
> checked but their calls get no method targets, so the call is made
> dynamically with {{ScriptBytecodeAdapter.invokeMethodOnCurrent}}, which takes
> a {{GroovyObject}}. {{with}}, {{tap}} and other delegating closures in such
> blocks fail with any delegate that is not a Groovy object. 4.0.33 returns
> {{[ab]}}.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
