[ 
https://issues.apache.org/jira/browse/GROOVY-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18134551#comment-18134551
 ] 

ASF GitHub Bot commented on GROOVY-12577:
-----------------------------------------

codecov-commenter commented on PR #3103:
URL: https://github.com/apache/groovy/pull/3103#issuecomment-6512415722

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3103?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :x: Patch coverage is `50.00000%` with `1 line` in your changes missing 
coverage. Please review.
   :white_check_mark: Project coverage is 73.6746%. Comparing base 
([`5b077f9`](https://app.codecov.io/gh/apache/groovy/commit/5b077f9dcf610898e3415f1f1cebbaab8eecab61?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`5c48df2`](https://app.codecov.io/gh/apache/groovy/commit/5c48df220bab78575d1db1ecd9adc49303e480c9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/3103?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...groovy/classgen/asm/sc/StaticInvocationWriter.java](https://app.codecov.io/gh/apache/groovy/pull/3103?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2Fsc%2FStaticInvocationWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9zYy9TdGF0aWNJbnZvY2F0aW9uV3JpdGVyLmphdmE=)
 | 50.0000% | [0 Missing and 1 partial :warning: 
](https://app.codecov.io/gh/apache/groovy/pull/3103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/3103/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/3103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #3103        +/-   ##
   ==================================================
   + Coverage     73.6711%   73.6746%   +0.0035%     
   - Complexity      42584      42590         +6     
   ==================================================
     Files            1678       1678                
     Lines          146907     146915         +8     
     Branches        27790      27793         +3     
   ==================================================
   + Hits           108228     108239        +11     
   + Misses          28528      28526         -2     
   + Partials        10151      10150         -1     
   ```
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/3103?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[...groovy/classgen/asm/sc/StaticInvocationWriter.java](https://app.codecov.io/gh/apache/groovy/pull/3103?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2Fsc%2FStaticInvocationWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9zYy9TdGF0aWNJbnZvY2F0aW9uV3JpdGVyLmphdmE=)
 | `75.3304% <50.0000%> (-0.1121%)` | :arrow_down: |
   
   ... and [14 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/3103/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> SC: a method of Class called without a receiver in a static method fails 
> verification
> -------------------------------------------------------------------------------------
>
>                 Key: GROOVY-12577
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12577
>             Project: Groovy
>          Issue Type: Bug
>          Components: Static compilation
>    Affects Versions: 5.0.8, 6.0.0
>            Reporter: Scott Murphy Heiberg
>            Priority: Major
>
> {code:groovy}
> @groovy.transform.CompileStatic
> class C {
>     static String m() { getSimpleName() }
> }
> C.m() // VerifyError: Bad local variable type ... C.m()Ljava/lang/String; @0: 
> aload_0
> {code}
> In a static method or static initializer, {{this}} is the class object, and 
> the type checker accepts a call to a method of {{Class}} without a receiver, 
> like {{getName()}}, {{getSimpleName()}} or {{toString()}}. The static 
> invocation writer treats the method as one of an enclosing class and loads 
> {{Class.this}}, local variable 0, which does not exist in a static method. 
> Methods of {{Object}}, such as {{hashCode()}}, work. 4.0.33 returns {{'C'}}, 
> as dynamic Groovy and an explicit {{this.getSimpleName()}} do.
> PR: https://github.com/apache/groovy/pull/3103



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to