[ 
https://issues.apache.org/jira/browse/GROOVY-12564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18134457#comment-18134457
 ] 

ASF GitHub Bot commented on GROOVY-12564:
-----------------------------------------

codecov-commenter commented on PR #3093:
URL: https://github.com/apache/groovy/pull/3093#issuecomment-6508066997

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3093?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 73.6787%. Comparing base 
([`5b077f9`](https://app.codecov.io/gh/apache/groovy/commit/5b077f9dcf610898e3415f1f1cebbaab8eecab61?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`6b0de94`](https://app.codecov.io/gh/apache/groovy/commit/6b0de94ba64b613002f30bcabf3535c69fd60cbe?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/3093/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/3093?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #3093        +/-   ##
   ==================================================
   + Coverage     73.6711%   73.6787%   +0.0076%     
   - Complexity      42584      42591         +7     
   ==================================================
     Files            1678       1678                
     Lines          146907     146915         +8     
     Branches        27790      27793         +3     
   ==================================================
   + Hits           108228     108245        +17     
   + Misses          28528      28522         -6     
   + Partials        10151      10148         -3     
   ```
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/3093?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3093?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh)
 | `87.4775% <100.0000%> (+0.0113%)` | :arrow_up: |
   
   ... and [14 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/3093/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> STC: calling a closure of intersection type is typed as "?", giving 
> NoClassDefFoundError: ?
> -------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-12564
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12564
>             Project: Groovy
>          Issue Type: Bug
>          Components: Static Type Checker
>    Affects Versions: 4.0.33, 5.0.8, 6.0.0
>            Reporter: Scott Murphy Heiberg
>            Priority: Major
>
> A closure whose return type is an intersection, such as the value of {{flag ? 
> 1 : 'x'}}, is typed {{Closure<? extends A & B>}}. A call of such a closure 
> through a variable is typed as the wildcard's placeholder class, named "?". A 
> closure returning that call gets a {{doCall}} declared to return class "?":
> {code:groovy}
> @groovy.transform.CompileStatic
> Object make(boolean flag) { def outer = { def inner = { flag ? 1 : 'x' }; 
> inner() }; outer() }
> make(true) // NoClassDefFoundError: ?
> {code}
> The same under {{@TypeChecked}}, in traits, and in static methods and field 
> initializers.
> Expected: the call is typed as the wildcard's upper bound (the closure's 
> return type).
> PR: https://github.com/apache/groovy/pull/3093



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to