codeconsole commented on PR #3095: URL: https://github.com/apache/groovy/pull/3095#issuecomment-6526836227
@daniellansun thanks. The timed-out `lts (17, windows-latest, 1)` and `lts (17, macos-latest)` cells hit the 60m Gradle step timeout, not a test failure. I merged master, which re-runs the whole matrix (a fork author cannot re-run jobs). On codecov: the coverage job (`groovy-build-coverage.yml`) runs on JDK 21, where `STRONG_AS_TYPE_CACHE` is false. So the holes are the JDK 17 branches: in `IndyGuardsFiltersAndSignatures.unshared`, `!STRONG_AS_TYPE_CACHE` short-circuits, so the `handle.type().equals(type)` check and the `exactInvoker(...).bindTo(handle)` line never run; in `Selector.addExceptionHandler`, `STRONG_AS_TYPE_CACHE ? type.erase() : type` only takes the `type` side. Those branches run in the `lts (17, *)` cells, where `Groovy12142.testDynamicCallsKeepNoDiscardedScriptLoaderReachable` covers them. It also passes locally on 17.0.20. Land order: #3096 is stacked on this PR and already contains it. This one should merge first; #3096 then shows only its GROOVY-12580 commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
