codeconsole commented on PR #3049: URL: https://github.com/apache/groovy/pull/3049#issuecomment-6536726382
Merged master now that #3071 (GROOVY-12526) has landed. The conflicts were textual: COMPATIBILITY.md keeps master's GROOVY-12488 section ahead of the GROOVY-12514/12517 one, and `ClosuresSTCTest` keeps both new tests. Since this PR merges second, `Groovy12526.testEnclosingClassSuperIsOutsideTheInterfaceCheck` (7b7060ca52) no longer expects "No such property: super": it asserts that `D.super.value()` from an inner class of `D` returns `'C'`, the method of `D`'s superclass, in dynamic, `@TypeChecked` and `@CompileStatic` code. The order fits #3071: `ResolveVisitor` checks the direct-superinterface rule for `Iface.super` first and rewrites `N.super` to `super` only after that, for a nested class that is not an interface; in `existsProperty` the interface branch also runs before the `Outer.super` branch. `MethodReferenceTest.testMethodReferencesInStaticAndDefaultMethodsOfInterface` fails on master itself (`ClassFormatError: ... illegal modifiers: 0x101A` for the GROOVY-12536 GString adapter generated `private final` in an interface), so CI here will show it too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
