[
https://issues.apache.org/jira/browse/GROOVY-12589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135511#comment-18135511
]
ASF GitHub Bot commented on GROOVY-12589:
-----------------------------------------
testlens-app[bot] commented on PR #3114:
URL: https://github.com/apache/groovy/pull/3114#issuecomment-6537020136
## 🚨 TestLens detected 1 failed test 🚨
### Test Summary
> [!TIP]
> Inspect all details with the [TestLens
CLI](https://testlens.app/docs/features/cli): `testlens pr 3114`
#### [Build and test / lts \(25,
ubuntu-latest\)](https://github.com/apache/groovy/actions/runs/41152081168/job/124390677629?pr=3114)
> :test
| Test | Runs | Flakiness |
|---|---|--:|
| MethodReferenceTest >
testMethodReferencesInStaticAndDefaultMethodsOfInterface\(\) | ❌ | 0% 🟢 |
🏷️ Commit: c64c35e2a13bea111effa609502a4d6ff3491d3c
▶️ Tests: 73766 executed
🟡 Checks: 12/24 completed
### Test Failures
<details><summary><strong>MethodReferenceTest >
testMethodReferencesInStaticAndDefaultMethodsOfInterface()</strong> (:test in
<a
href="https://github.com/apache/groovy/actions/runs/41152081168/job/124390677629?pr=3114";>Build
and test / lts (25, ubuntu-latest)</a>)</summary>
```
java.lang.ClassFormatError: Method gstring$I$ctorRef$make$0$1 in class I has
illegal modifiers: 0x101A
at java.base/java.lang.ClassLoader.defineClass1(Native Method)
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:962)
at
java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:144)
at groovy.lang.GroovyClassLoader.access$000(GroovyClassLoader.java:90)
at
groovy.lang.GroovyClassLoader$ClassCollector.createClass(GroovyClassLoader.java:1305)
at groovy.lang.GroovyClassLoader.collect(GroovyClassLoader.java:284)
at
groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:440)
at
groovy.lang.GroovyClassLoader.lambda$parseClass$2(GroovyClassLoader.java:378)
at
org.codehaus.groovy.runtime.memoize.ConcurrentCommonCache.getAndPut(ConcurrentCommonCache.java:143)
at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:378)
at groovy.lang.GroovyShell.parseClass(GroovyShell.java:664)
at groovy.lang.GroovyShell.parse(GroovyShell.java:677)
at groovy.lang.GroovyShell.parse(GroovyShell.java:689)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:551)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:587)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:571)
at groovy.test.GroovyAssert.assertScript(GroovyAssert.java:107)
at
groovy.transform.stc.MethodReferenceTest.testMethodReferencesInStaticAndDefaultMethodsOfInterface(MethodReferenceTest.groovy:1613)
```
</details>
### Rerun Controls
> [!NOTE]
> Checks are currently running using the configuration below.
Select tests to mute in this pull request:
🔲 MethodReferenceTest >
testMethodReferencesInStaticAndDefaultMethodsOfInterface\(\) <!
> SC: super.name within a class nested in its superclass calls the wrong
> accessor or throws MissingPropertyException
> ------------------------------------------------------------------------------------------------------------------
>
> Key: GROOVY-12589
> URL: https://issues.apache.org/jira/browse/GROOVY-12589
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 4.0.33, 5.0.8, 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> {code:groovy}
> import groovy.transform.*
> class Base {
> boolean f
> boolean isF() { true }
> boolean getF() { false }
> @CompileStatic
> static class Sub extends Base {
> boolean isF() { false }
> boolean getF() { true }
> def plain() { super.f }
> def test() { def c = { -> super.f }; c() }
> }
> }
> assert new Base.Sub().plain()
> assert new Base.Sub().test()
> {code}
> Actual: groovy.lang.MissingPropertyException: No such property: f for class:
> Base$Sub, for both methods. If Sub overrides only isF, both return the result
> of Base.getF instead. The same happens for any property whose getter Sub
> overrides (for example String x with getX), and assigning super.x in a
> closure throws VerifyError.
> Expected: both assertions pass. Base.isF is called, as in dynamic Groovy.
> Within a class nested in its superclass, the type checker resolves super.f as
> the superclass field that the nested class may access, so it records no
> accessor and requests no super$ helper, and static compilation falls back to
> a dynamic getPropertyOnSuper call. That call cannot reach the overridden
> accessors of a statically compiled class, which has no MOP methods. A plain
> subclass that is not nested in its superclass is not affected.
> Seen in 4.0.33, 5.0.8, 6.0.0 and master. With PR #3049 (GROOVY-12518) the
> plain super.f works and only the closure and lambda forms fail.
> PR: https://github.com/apache/groovy/pull/3114
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
