[
https://issues.apache.org/jira/browse/GROOVY-12592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135568#comment-18135568
]
ASF GitHub Bot commented on GROOVY-12592:
-----------------------------------------
codecov-commenter commented on PR #3118:
URL: https://github.com/apache/groovy/pull/3118#issuecomment-6539387991
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3118?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.0988%. Comparing base
([`12ce174`](https://app.codecov.io/gh/apache/groovy/commit/12ce174090162bdded6fb759c8af39ebd1593353?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`81d2ef9`](https://app.codecov.io/gh/apache/groovy/commit/81d2ef9f34525c4800e0c55e75fc287062ea136b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 63 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/3118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #3118 +/- ##
==================================================
+ Coverage 73.7672% 74.0988% +0.3317%
- Complexity 42748 43591 +843
==================================================
Files 1678 1692 +14
Lines 147464 149248 +1784
Branches 27899 28286 +387
==================================================
+ Hits 108780 110591 +1811
+ Misses 28520 28476 -44
- Partials 10164 10181 +17
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3118?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/3118?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=)
| `79.1991% <100.0000%> (+0.0348%)` | :arrow_up: |
... and [66 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/3118/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Outer.super.name() and super.name() in a closure skip the method the class
> inherits
> -----------------------------------------------------------------------------------
>
> Key: GROOVY-12592
> URL: https://issues.apache.org/jira/browse/GROOVY-12592
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 4.0.33, 5.0.8, 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> {code:groovy}
> class Base { String m() { 'base' } }
> class Root extends Base { String m() { 'root' } }
> class Outer extends Root {
> class Inner { String test() { Outer.super.m() } }
> String viaClosure() { def c = { -> super.m() }; c() }
> }
> def o = new Outer()
> assert new Outer.Inner(o).test() == 'root'
> assert o.viaClosure() == 'root'
> {code}
> Actual: both calls return 'base'.
> Expected: both return 'root', the method Outer inherits from Root, as a super
> call in a method of Outer does.
> A super call from a nested class or a closure does not create a super$ MOP
> method in Outer. MetaClassImpl then takes the super$ MOP method of Root,
> which calls Root's super method, Base.m, so Root's override is skipped. The
> closure form is the same in 4.0.33; Outer.super is not supported there.
> PR: https://github.com/apache/groovy/pull/3118
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
