[
https://issues.apache.org/jira/browse/GROOVY-12315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135571#comment-18135571
] ASF GitHub Bot commented on GROOVY-12315: ----------------------------------------- codecov-commenter commented on PR #3119: URL: https://github.com/apache/groovy/pull/3119#issuecomment-6539418510 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/3119?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.48649%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 74.0837%. Comparing base ([`cd944a5`](https://app.codecov.io/gh/apache/groovy/commit/cd944a5f0ee353126e6f6a484f574b4b53e555fd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c63810`](https://app.codecov.io/gh/apache/groovy/commit/3c63810c4ff0d94b5486a2fa526e17fd017295b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3119?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3119?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh) | 86.4865% | [0 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/3119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/3119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #3119 +/- ## ================================================== - Coverage 74.1016% 74.0837% -0.0180% + Complexity 43596 43535 -61 ================================================== Files 1692 1692 Lines 149245 149153 -92 Branches 28284 28246 -38 ================================================== - Hits 110593 110498 -95 Misses 28475 28475 - Partials 10177 10180 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3119?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3119?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh) | `87.8208% <86.4865%> (-0.3882%)` | :arrow_down: | ... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/3119/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Type for final field should be known by flow-typing > --------------------------------------------------- > > Key: GROOVY-12315 > URL: https://issues.apache.org/jira/browse/GROOVY-12315 > Project: Groovy > Issue Type: Bug > Affects Versions: 6.0.0-alpha-1, 5.0.3, 4.0.31 > Reporter: Björn Kautler > Assignee: Daniel Sun > Priority: Major > > This does not compile, while the type should be clear as the field is final: > {code:java} > @groovy.transform.CompileStatic > class Foo { > final bar = '' > def foo() { > println(bar.length()) > } > } > new Foo().foo() {code} > With a local variable it works even without {{{}final{}}}. -- This message was sent by Atlassian Jira (v10.3.26#10030026)
