[
https://issues.apache.org/jira/browse/GROOVY-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135582#comment-18135582
]
ASF GitHub Bot commented on GROOVY-12490:
-----------------------------------------
testlens-app[bot] commented on PR #3024:
URL: https://github.com/apache/groovy/pull/3024#issuecomment-6539529845
## 🚨 TestLens detected 1 failed test 🚨
### Test Summary
> [!TIP]
> Inspect all details with the [TestLens
CLI](https://testlens.app/docs/features/cli): `testlens pr 3024`
#### [Build and test / lts \(17, windows-latest,
1\)](https://github.com/apache/groovy/actions/runs/41169491627/job/124444158897?pr=3024)
> :test
| Test | Runs | Flakiness |
|---|---|--:|
| ParallelCollectionTest > testEachParallelRunsConcurrently\(\) | ❌ |
1% 🟡 |
🏷️ Commit: 3c73e9055b92724b01403777a829f48cb9e48ead
▶️ Tests: 37630 executed
🟡 Checks: 16/24 completed
### Test Failures
<details><summary><strong>ParallelCollectionTest >
testEachParallelRunsConcurrently()</strong> (:test in <a
href="https://github.com/apache/groovy/actions/runs/41169491627/job/124444158897?pr=3024";>Build
and test / lts (17, windows-latest, 1)</a>)</summary>
```
java.lang.reflect.UndeclaredThrowableException
at
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
Method)
at
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
at
java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at
java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
at
java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
at
java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:562)
at
java.base/java.util.concurrent.ForkJoinTask.reportException(ForkJoinTask.java:591)
at
java.base/java.util.concurrent.ForkJoinTask.join(ForkJoinTask.java:672)
at
org.codehaus.groovy.runtime.ParallelCollectionExtensions.lambda$eachParallel$1(ParallelCollectionExtensions.java:118)
at
org.codehaus.groovy.runtime.ParallelCollectionExtensions.withPool(ParallelCollectionExtensions.java:405)
at
org.codehaus.groovy.runtime.ParallelCollectionExtensions.eachParallel(ParallelCollectionExtensions.java:117)
at TestScript109$_run_closure1$_closure2.doCall(TestScript109.groovy:19)
at groovy.lang.Closure.invokeHandle(Closure.java:647)
at groovy.lang.Closure.invokeCached(Closure.java:618)
at groovy.lang.Closure.call(Closure.java:584)
at groovy.lang.Closure.call(Closure.java:543)
at
org.codehaus.groovy.runtime.DefaultGroovyMethods.times(DefaultGroovyMethods.java:17402)
at TestScript109$_run_closure1.doCall(TestScript109.groovy:15)
at groovy.lang.Closure.invokeHandle(Closure.java:647)
at groovy.lang.Closure.invokeCached(Closure.java:618)
at groovy.lang.Closure.call(Closure.java:584)
at
org.codehaus.groovy.runtime.ConvertedClosure.invokeCustom(ConvertedClosure.java:55)
at
org.codehaus.groovy.runtime.ConversionHandler.invoke(ConversionHandler.java:130)
at jdk.proxy2/jdk.proxy2.$Proxy53.apply(Unknown Source)
at groovy.concurrent.AsyncScope.lambda$withScope$0(AsyncScope.java:167)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.lambda$call$0(ScopedLocal.java:320)
at
org.apache.groovy.runtime.async.ScopedLocal$ThreadLocalImpl.bind(ScopedLocal.java:428)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.lambda$execute$1(ScopedLocal.java:338)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.execute(ScopedLocal.java:340)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.call(ScopedLocal.java:320)
at
org.apache.groovy.runtime.async.ScopedLocal.where(ScopedLocal.java:220)
at
org.apache.groovy.runtime.async.DefaultAsyncScope.withCurrent(DefaultAsyncScope.java:99)
at groovy.concurrent.AsyncScope.withCurrent(AsyncScope.java:121)
at groovy.concurrent.AsyncScope.withScope(AsyncScope.java:167)
at
groovy.concurrent.ParallelScope.lambda$withPool$1(ParallelScope.java:92)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.lambda$call$0(ScopedLocal.java:320)
at
org.apache.groovy.runtime.async.ScopedLocal$ThreadLocalImpl.bind(ScopedLocal.java:428)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.lambda$execute$1(ScopedLocal.java:338)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.execute(ScopedLocal.java:340)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.call(ScopedLocal.java:320)
at
org.apache.groovy.runtime.async.ScopedLocal.where(ScopedLocal.java:220)
at
org.apache.groovy.runtime.async.DefaultPool.withCurrent(DefaultPool.java:262)
at groovy.concurrent.Pool.withCurrent(Pool.java:152)
at groovy.concurrent.ParallelScope.withPool(ParallelScope.java:92)
at TestScript109.run(TestScript109.groovy:13)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:552)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:587)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:571)
at groovy.test.GroovyAssert.assertScript(GroovyAssert.java:107)
at groovy.test.GroovyAssert.assertScript(GroovyAssert.java:97)
at
groovy.concurrent.ParallelCollectionTest.testEachParallelRunsConcurrently(ParallelCollectionTest.groovy:48)
Caused by: java.lang.reflect.UndeclaredThrowableException
at jdk.proxy2/jdk.proxy2.$Proxy61.accept(Unknown Source)
at
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at
java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
at
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at
java.base/java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290)
at
java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:754)
at
java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at
java.base/java.util.concurrent.ForkJoinPool$WorkQueue.helpComplete(ForkJoinPool.java:1234)
at
java.base/java.util.concurrent.ForkJoinPool.helpComplete(ForkJoinPool.java:1926)
at
java.base/java.util.concurrent.ForkJoinTask.awaitDone(ForkJoinTask.java:433)
at
java.base/java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:687)
at
java.base/java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:159)
at
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:173)
at
java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
at
java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at
java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:765)
at
org.codehaus.groovy.runtime.ParallelCollectionExtensions.lambda$eachParallel$0(ParallelCollectionExtensions.java:118)
at
java.base/java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1375)
at
java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at
java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1193)
at
java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1666)
at
java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1633)
at
java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
Caused by: java.util.concurrent.TimeoutException
at
java.base/java.util.concurrent.CyclicBarrier.dowait(CyclicBarrier.java:259)
at
java.base/java.util.concurrent.CyclicBarrier.await(CyclicBarrier.java:437)
at
TestScript109$_run_closure1$_closure2$_closure3.doCall(TestScript109.groovy:21)
at groovy.lang.Closure.invokeHandle(Closure.java:647)
at groovy.lang.Closure.invokeCached(Closure.java:618)
at groovy.lang.Closure.call(Closure.java:584)
at
org.codehaus.groovy.runtime.ConvertedClosure.invokeCustom(ConvertedClosure.java:55)
at
org.codehaus.groovy.runtime.ConversionHandler.invoke(ConversionHandler.java:130)
... 23 more
```
</details>
### Rerun Controls
> [!NOTE]
> Checks are currently running using the configuration below.
Select tests to mute in this pull request:
🔲 ParallelCollectionTest > testEachParallelRunsConcurrently\(\) <!
> Enum constants with literal arguments still select their constructor
> reflectively through $INIT
> -----------------------------------------------------------------------------------------------
>
> Key: GROOVY-12490
> URL: https://issues.apache.org/jira/browse/GROOVY-12490
> Project: Groovy
> Issue Type: Improvement
> Components: Compiler
> Affects Versions: 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> GROOVY-12240 made enum constants without arguments call the {{(String,int)}}
> constructor directly. Every constant with arguments still goes through the
> synthetic {{$INIT(Object[])}} helper, whose body is a spread {{this(*para)}}:
> {{MetaClassImpl}} selects the constructor by reflecting over the declared
> constructors. {{@CompileStatic}} does not change that, since {{$INIT}}'s own
> body stays dynamic.
> As a result, an ordinary enum fails to initialize in a GraalVM native image
> built without reflection metadata for it:
> {code:groovy}
> enum AccessModifier {
> PRIVATE('private'), PROTECTED('protected'), PUBLIC('public')
> final String keyword
> AccessModifier(String keyword) { this.keyword = keyword }
> }
> {code}
> As written, the enum fails at the dynamic call to {{$INIT}} itself:
> {noformat}
> groovy.lang.MissingMethodException: No signature of static method: $INIT for
> class: AccessModifier is applicable for argument types: (String, Integer,
> String)
> {noformat}
> With {{@CompileStatic}} on the enum, {{$INIT}} is called with
> {{invokestatic}}, and the constructor selection in its body fails instead:
> {noformat}
> groovy.lang.GroovyRuntimeException: Could not find matching constructor for:
> AccessModifier(String, Integer, String)
> {noformat}
> Proposed fix: call the constructor directly when the compiler can prove what
> the runtime would do: every argument is a literal, exactly one non-synthetic
> constructor has the arity and none could take the arguments as varargs, and
> each literal reaches its parameter unchanged ({{Boolean}} parameters
> excluded). Everything else keeps {{$INIT}}, and the decision stays per enum,
> as in GROOVY-12240.
> PR: https://github.com/apache/groovy/pull/3024
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
