[
https://issues.apache.org/jira/browse/GROOVY-12604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135632#comment-18135632
]
ASF GitHub Bot commented on GROOVY-12604:
-----------------------------------------
codecov-commenter commented on PR #3131:
URL: https://github.com/apache/groovy/pull/3131#issuecomment-6539918205
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3131?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `95.00000%` with `1 line` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 74.0986%. Comparing base
([`cd944a5`](https://app.codecov.io/gh/apache/groovy/commit/cd944a5f0ee353126e6f6a484f574b4b53e555fd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`644c189`](https://app.codecov.io/gh/apache/groovy/commit/644c189bbb76de82c62cdc933dbe7a18b5404c03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3131?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...oovy/transform/trait/TraitReceiverTransformer.java](https://app.codecov.io/gh/apache/groovy/pull/3131?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Ftrait%2FTraitReceiverTransformer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS90cmFpdC9UcmFpdFJlY2VpdmVyVHJhbnNmb3JtZXIuamF2YQ==)
| 95.0000% | [1 Missing :warning:
](https://app.codecov.io/gh/apache/groovy/pull/3131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/3131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #3131 +/- ##
==================================================
- Coverage 74.1016% 74.0986% -0.0030%
- Complexity 43596 43603 +7
==================================================
Files 1692 1692
Lines 149245 149270 +25
Branches 28284 28292 +8
==================================================
+ Hits 110593 110607 +14
- Misses 28475 28480 +5
- Partials 10177 10183 +6
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3131?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...oovy/transform/trait/TraitReceiverTransformer.java](https://app.codecov.io/gh/apache/groovy/pull/3131?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Ftrait%2FTraitReceiverTransformer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS90cmFpdC9UcmFpdFJlY2VpdmVyVHJhbnNmb3JtZXIuamF2YQ==)
| `89.6714% <95.0000%> (+0.8389%)` | :arrow_up: |
... and [16 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/3131/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> A promoted trait static that calls a @Virtual static fails with
> MissingMethodException when called through the trait
> --------------------------------------------------------------------------------------------------------------------
>
> Key: GROOVY-12604
> URL: https://issues.apache.org/jira/browse/GROOVY-12604
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> {code:groovy}
> import groovy.transform.Virtual
> trait T {
> @Virtual static String setting() { 'default' }
> static String describe() { 'setting=' + setting() }
> }
> class C implements T {}
> assert C.describe() == 'setting=default'
> assert T.describe() == 'setting=default'
> {code}
> Actual: {{T.describe()}} throws {{MissingMethodException: No signature of
> static method: setting for class: T is applicable for argument types: ()
> values: []}}. This happens in dynamic Groovy, with @TypeChecked and with
> @CompileStatic. The trait documentation's own @Virtual example fails the same
> way when called as {{Configurable.describe()}}.
> Expected: called through the trait itself there is no implementing class, so
> the trait's own (default) implementation of the @Virtual static is used, and
> the call returns {{setting=default}}.
> Public trait statics are promoted to the trait interface, and the forwarder
> passes the trait interface as the static self. The @Virtual call site
> dispatches dynamically on that self, but @Virtual statics are deliberately
> not promoted to the interface, so the call finds nothing.
> Seen in 6.0.0 (the first version with @Virtual).
> PR: https://github.com/apache/groovy/pull/3131
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
