[
https://issues.apache.org/jira/browse/GROOVY-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135700#comment-18135700
]
ASF GitHub Bot commented on GROOVY-12625:
-----------------------------------------
codecov-commenter commented on PR #3151:
URL: https://github.com/apache/groovy/pull/3151#issuecomment-6540785422
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3151?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.1012%. Comparing base
([`ef76fcb`](https://app.codecov.io/gh/apache/groovy/commit/ef76fcba756be3331227627f78b5ba6b62109645?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`5aa432b`](https://app.codecov.io/gh/apache/groovy/commit/5aa432bb7d4637d4f49b9feac6cee0e8bb0d6ccd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/3151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #3151 +/- ##
=============================================
Coverage 74.1012% 74.1012%
+ Complexity 43600 43599 -1
=============================================
Files 1692 1692
Lines 149254 149258 +4
Branches 28286 28287 +1
=============================================
+ Hits 110599 110602 +3
- Misses 28475 28477 +2
+ Partials 10180 10179 -1
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3151?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3151?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh)
| `88.2190% <100.0000%> (+0.0100%)` | :arrow_up: |
... and [13 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/3151/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> SC fails with ArrayIndexOutOfBoundsException for ++ or -- on a subscript
> whose element type is not a primitive or wrapper number type
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GROOVY-12625
> URL: https://issues.apache.org/jira/browse/GROOVY-12625
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 4.0.33, 5.0.8, 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> {code:groovy}
> @groovy.transform.CompileStatic
> def f() {
> List<BigDecimal> l = [1.0]
> l[0]++
> l
> }
> assert f() == [2.0]
> {code}
> Actual: compilation fails with "General error during instruction selection:
> Index 1 out of bounds for length 1" (ArrayIndexOutOfBoundsException in
> StaticInvocationWriter.loadArguments). The same happens for prefix and
> postfix ++ and -- on a BigDecimal array, a map of BigDecimal values, a list
> of BigInteger, String, Character, char[], and a class with getAt/putAt
> returning BigDecimal.
> Expected: the code compiles and the assertion passes, as it does without the
> annotation and with @TypeChecked.
> The type checker resolves next() or previous() by passing the subscript
> expression to findMethodOrFail. StaticCompilationVisitor then stores next()
> as that expression's binary target, replacing getAt, so l[0] is compiled as a
> call to next with argument 0.
> Seen in 4.0.33, 5.0.8 and 6.0.0.
> PR: https://github.com/apache/groovy/pull/3151
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
