[ 
https://issues.apache.org/jira/browse/GROOVY-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18137500#comment-18137500
 ] 

ASF GitHub Bot commented on GROOVY-12675:
-----------------------------------------

codecov-commenter commented on PR #3196:
URL: https://github.com/apache/groovy/pull/3196#issuecomment-6612334127

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3196?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 74.1606%. Comparing base 
([`0941dba`](https://app.codecov.io/gh/apache/groovy/commit/0941dbacf496a1667c27681c6fe76deee59bfb57?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`e0d078f`](https://app.codecov.io/gh/apache/groovy/commit/e0d078f1b8791708a9a0f0910b4ba06687b506d5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 11 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/3196/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/3196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #3196        +/-   ##
   ==================================================
   + Coverage     74.1533%   74.1606%   +0.0074%     
   - Complexity      43751      43760         +9     
   ==================================================
     Files            1692       1692                
     Lines          149516     149520         +4     
     Branches        28366      28368         +2     
   ==================================================
   + Hits           110871     110885        +14     
   + Misses          28448      28439         -9     
   + Partials        10197      10196         -1     
   ```
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/3196?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[...aus/groovy/runtime/metaclass/ClosureMetaClass.java](https://app.codecov.io/gh/apache/groovy/pull/3196?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2Fmetaclass%2FClosureMetaClass.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvbWV0YWNsYXNzL0Nsb3N1cmVNZXRhQ2xhc3MuamF2YQ==)
 | `73.0769% <100.0000%> (+1.0911%)` | :arrow_up: |
   
   ... and [13 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/3196/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> MissingPropertyException for a closure suggests the private field Closure.bcw
> -----------------------------------------------------------------------------
>
>                 Key: GROOVY-12675
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12675
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 4.0.33, 5.0.8, 7.0.0-alpha-1, 6.0.0
>            Reporter: Scott Murphy Heiberg
>            Priority: Major
>
> {code:groovy}
> def c = { -> 1 }
> c.metaClass.getProperty(c, 'bar')
> {code}
> *Actual:*
> {noformat}
> groovy.lang.MissingPropertyException: No such property: bar for class: 
> Script1$_run_closure1
> Possible solutions: bcw
> {noformat}
> In the same way, {{thisTyp}} suggests {{thisType}} and {{serialVersionUI}} 
> suggests {{serialVersionUID}}. {{c.metaClass.properties}} lists these and the 
> other private members of {{groovy.lang.Closure}}.
> *Expected:* no suggestion of private members of {{Closure}}. A closure class 
> does not inherit them, and the metaclass of any other {{Closure}} subclass 
> does not list them.
> Cause: {{ClosureMetaClass.getProperties}} returns the property list of the 
> metaclass of {{Closure}} itself, which includes Closure's own private fields 
> and properties. {{MethodRankHelper.getPropertySuggestionString}} ranks that 
> list for the "Possible solutions" text.
> Verified on 4.0.33, 5.0.8, 6.0.0 and master.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to