[
https://issues.apache.org/jira/browse/GROOVY-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18137522#comment-18137522
]
ASF GitHub Bot commented on GROOVY-12681:
-----------------------------------------
codecov-commenter commented on PR #3202:
URL: https://github.com/apache/groovy/pull/3202#issuecomment-6613032144
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3202?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `70.58824%` with `5 lines` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 74.1555%. Comparing base
([`0941dba`](https://app.codecov.io/gh/apache/groovy/commit/0941dbacf496a1667c27681c6fe76deee59bfb57?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`6fee305`](https://app.codecov.io/gh/apache/groovy/commit/6fee3059fef2ff48788a7cac56dc8f1f27e99d37?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3202?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...a/org/codehaus/groovy/runtime/IOGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/3202?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FIOGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvSU9Hcm9vdnlNZXRob2RzLmphdmE=)
| 70.5882% | [4 Missing and 1 partial :warning:
](https://app.codecov.io/gh/apache/groovy/pull/3202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/3202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #3202 +/- ##
==================================================
+ Coverage 74.1533% 74.1555% +0.0023%
- Complexity 43751 43762 +11
==================================================
Files 1692 1692
Lines 149516 149533 +17
Branches 28366 28371 +5
==================================================
+ Hits 110871 110887 +16
- Misses 28448 28449 +1
Partials 10197 10197
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3202?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...a/org/codehaus/groovy/runtime/IOGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/3202?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FIOGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvSU9Hcm9vdnlNZXRob2RzLmphdmE=)
| `89.1688% <70.5882%> (-0.8312%)` | :arrow_down: |
... and [13 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/3202/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> withObjectInputStream(ClassLoader) and newObjectInputStream(ClassLoader) do
> not use the given class loader for the interfaces of a serialized Proxy
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GROOVY-12681
> URL: https://issues.apache.org/jira/browse/GROOVY-12681
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 4.0.33, 5.0.8, 7.0.0-alpha-1, 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> {code:groovy}
> import java.lang.reflect.Proxy
> def gcl = new GroovyClassLoader()
> def i = gcl.parseClass('interface Greeter { String greet() }')
> def h = gcl.parseClass('''class H implements
> java.lang.reflect.InvocationHandler, Serializable {
> Object invoke(Object p, java.lang.reflect.Method m, Object[] a) { 'hi' }
> }''')
> def proxy = Proxy.newProxyInstance(gcl, [i] as Class[],
> h.getDeclaredConstructor().newInstance())
> def bytes = new ByteArrayOutputStream()
> bytes.withObjectOutputStream { it.writeObject(proxy) }
> println new
> ByteArrayInputStream(bytes.toByteArray()).withObjectInputStream(gcl) {
> it.readObject().greet() }
> {code}
> *Actual:* {{java.lang.ClassNotFoundException: Greeter}}. A plain instance of
> {{H}} reads back fine through the same loader.
> *Expected:* prints {{hi}}; the proxy's interfaces resolve through the given
> class loader, like every other class in the stream.
> The stream returned by {{IOGroovyMethods.newObjectInputStream(InputStream,
> ClassLoader)}} overrides {{resolveClass}} but not {{resolveProxyClass}}. The
> JDK default resolves proxy interfaces through the latest user-defined loader
> on the call stack, which here is the script's loader. All class-loader
> variants on InputStream, File and Path go through this method. Related:
> GROOVY-12676.
> Verified on 4.0.33, 5.0.8, 6.0.0 and master.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
