[
https://issues.apache.org/jira/browse/GROOVY-12714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18140025#comment-18140025
] ASF GitHub Bot commented on GROOVY-12714: ----------------------------------------- codecov-commenter commented on PR #3246: URL: https://github.com/apache/groovy/pull/3246#issuecomment-6699656938 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/3246?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `69.81132%` with `16 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 74.3982%. Comparing base ([`8943df2`](https://app.codecov.io/gh/apache/groovy/commit/8943df2e31a8ee4f308dc64867d56b7c4768f82b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`81a5223`](https://app.codecov.io/gh/apache/groovy/commit/81a52237a1babc24b8ea531dd37c29067a70cb5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3246?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ain/java/org/codehaus/groovy/ast/GenericsType.java](https://app.codecov.io/gh/apache/groovy/pull/3246?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fast%2FGenericsType.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC9HZW5lcmljc1R5cGUuamF2YQ==) | 67.6471% | [4 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/3246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...roovy/transform/stc/StaticTypeCheckingSupport.java](https://app.codecov.io/gh/apache/groovy/pull/3246?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nU3VwcG9ydC5qYXZh) | 40.0000% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/3246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3246?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh) | 85.7143% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/3246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/3246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #3246 +/- ## ================================================== - Coverage 74.4044% 74.3982% -0.0063% - Complexity 44345 44367 +22 ================================================== Files 1699 1699 Lines 150995 151040 +45 Branches 28767 28790 +23 ================================================== + Hits 112347 112371 +24 - Misses 28375 28384 +9 - Partials 10273 10285 +12 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3246?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3246?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh) | `88.0361% <85.7143%> (-0.0092%)` | :arrow_down: | | [...roovy/transform/stc/StaticTypeCheckingSupport.java](https://app.codecov.io/gh/apache/groovy/pull/3246?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nU3VwcG9ydC5qYXZh) | `82.0883% <40.0000%> (-0.1794%)` | :arrow_down: | | [...ain/java/org/codehaus/groovy/ast/GenericsType.java](https://app.codecov.io/gh/apache/groovy/pull/3246?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fast%2FGenericsType.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC9HZW5lcmljc1R5cGUuamF2YQ==) | `84.8921% <67.6471%> (-1.5621%)` | :arrow_down: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/3246/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > `@CompileStatic` PECS wildcard containment diverges from javac (JLS 4.5.1) > -------------------------------------------------------------------------- > > Key: GROOVY-12714 > URL: https://issues.apache.org/jira/browse/GROOVY-12714 > Project: Groovy > Issue Type: Bug > Components: Static Type Checker > Reporter: Daniel Sun > Priority: Major > > h2. Problem > Under {{@CompileStatic}}, Groovy's generics / wildcard containment was more > permissive than javac for several JLS 4.5.1 PECS cases, including: > * adding a non-subtype into {{List<? super Integer>}} (e.g. {{add(Double)}}) > * treating {{? extends Number}} as contained in {{? extends Integer}} (and > the dual lower-bound mistake) > * assigning a wildcard producer {{List<? extends Number>}} to an invariant > {{List<Number>}} > h2. Fix > Align containment and capture write checks with JLS SE 25 §§4.5.1, 4.5.2, > 4.10.2, 5.1.10 so {{@CompileStatic}} matches javac. > h2. Tests > Extend {{gls.generics.GenericsJavaCompatibilityTest}} with PECS containment / > transfer / negative cases that both compilers must agree on. > h2. PR > https://github.com/apache/groovy/pull/3246 -- This message was sent by Atlassian Jira (v10.3.26#10030026)
