[
https://issues.apache.org/jira/browse/GROOVY-12715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139867#comment-18139867
]
ASF GitHub Bot commented on GROOVY-12715:
-----------------------------------------
codecov-commenter commented on PR #3248:
URL: https://github.com/apache/groovy/pull/3248#issuecomment-6694139015
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3248?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.3385%. Comparing base
([`d1710f8`](https://app.codecov.io/gh/apache/groovy/commit/d1710f88eb6ac98a941626db47963a063f1c50e0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`73a738e`](https://app.codecov.io/gh/apache/groovy/commit/73a738e7e10f12b8e0dc7696c5fc620b394c62b9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/3248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #3248 +/- ##
==================================================
+ Coverage 74.2207% 74.3385% +0.1178%
- Complexity 43914 44304 +390
==================================================
Files 1692 1699 +7
Lines 149911 150860 +949
Branches 28466 28755 +289
==================================================
+ Hits 111265 112147 +882
+ Misses 28444 28436 -8
- Partials 10202 10277 +75
```
[see 32 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/3248/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> A cast applied to await or to an async closure is parsed as a call to a
> method named await or async
> ---------------------------------------------------------------------------------------------------
>
> Key: GROOVY-12715
> URL: https://issues.apache.org/jira/browse/GROOVY-12715
> Project: Groovy
> Issue Type: Bug
> Components: parser-antlr4
> Affects Versions: 6.0.0
> Environment: Groovy 6.0.0 binary distribution and master 7379c5720d;
> BellSoft JDK 21.0.12; macOS 15 arm64
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> {{await}} and {{async}} are contextual keywords with their own alternatives
> in the {{expression}} rule of the grammar ({{awaitExprAlt}},
> {{asyncClosureExprAlt}}), but the operand of a cast is parsed by
> {{castOperandExpression}}, which lists only another cast, a
> {{postfixExpression}} and the unary operators. So after a cast the two words
> fall back to being identifiers, and {{(BigDecimal) await(price)}} is a call
> to a method named {{await}} with one argument, {{(Awaitable<Integer>) async {
> 7 }}} a call to a method named {{async}} with a closure. At script level that
> is a {{MissingMethodException}}; inside an async task the exception is
> swallowed by the task nobody awaits, and the code awaiting the task's result
> hangs.
> On 6.0.0 and master (JDK 21):
> {code:groovy}
> def t = async { 7 }
> Integer a = (Integer) await t // MissingMethodException: No
> signature of method: await for class: Script1 ...
> (groovy.concurrent.Awaitable)
> {code}
> {code:groovy}
> import groovy.concurrent.Awaitable
> Awaitable<Integer> t = (Awaitable<Integer>) async { 7 } //
> MissingMethodException: ... async ... (Script1$_run_closure1)
> {code}
> {code:groovy}
> import groovy.concurrent.DataflowVariable
> DataflowVariable<BigDecimal> price = new DataflowVariable<BigDecimal>()
> DataflowVariable<Integer> quantity = new DataflowVariable<Integer>()
> DataflowVariable<BigDecimal> total = new DataflowVariable<BigDecimal>()
> async {
> BigDecimal unitPrice = (BigDecimal) await(price) // parsed as
> this.await(price): the task fails
> Integer count = (Integer) await(quantity)
> total << unitPrice * count
> }
> async { quantity << 4 }
> async { price << 2.50 }
> println await(total) // hangs: total is
> never bound
> {code}
> The parenthesised forms {{(int) (await t)}} and {{-(await t)}} work, as do
> {{BigDecimal b = await(price)}} and {{await(price) as BigDecimal}}. Found
> because Claude Opus 5.5 wrote the cast form in every answer of an eval task
> under static typing; the script then timed out.
> Suggested fix: add the {{asyncClosureExprAlt}} and {{awaitExprAlt}}
> alternatives to {{castOperandExpression}} (it uses {{options { baseContext =
> expression; }}}, so the same labels reuse the same contexts and
> {{AstBuilder.visitAwaitExprAlt}} and {{visitAsyncClosureExprAlt}} apply
> unchanged). Pull request to follow.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
