[
https://issues.apache.org/jira/browse/GROOVY-12712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139731#comment-18139731
]
ASF GitHub Bot commented on GROOVY-12712:
-----------------------------------------
testlens-app[bot] commented on PR #3243:
URL: https://github.com/apache/groovy/pull/3243#issuecomment-6690116478
## 🚨 TestLens detected 2 failed tests 🚨
### Test Summary
> [!TIP]
> Inspect all details with the [TestLens
CLI](https://testlens.app/docs/features/cli): `testlens pr 3243`
#### [Build and test / lts \(17,
macos-latest\)](https://github.com/apache/groovy/actions/runs/42251469590/job/128007377936?pr=3243)
> :test
| Test | Runs | Flakiness |
|---|---|--:|
| ParserNegativeSyntaxTest > closed paren groups before a later syntax error
are not missing parens\(\) | ❌ | 0% 🟢 |
| ParserNegativeSyntaxTest > type pattern in case label after a record
declaration\(\) | ❌ | 0% 🟢 |
🏷️ Commit: e20b8f8c1ca6f2e2ea824e35ee3fed4fb5a1a3c1
▶️ Tests: 66338 executed
🟡 Checks: 8/24 completed
### Test Failures
<details><summary><strong>ParserNegativeSyntaxTest > closed paren groups
before a later syntax error are not missing parens()</strong> (:test in <a
href="https://github.com/apache/groovy/actions/runs/42251469590/job/128007377936?pr=3243";>Build
and test / lts (17, macos-latest)</a>)</summary>
```
org.opentest4j.AssertionFailedError: expected parse to fail
at org.junit.jupiter.api.Assertions.fail(Assertions.java:142)
at
org.apache.groovy.parser.antlr4.TestUtils.compileMessage(TestUtils.groovy:130)
at
org.apache.groovy.parser.antlr4.TestUtils.expectParseError(TestUtils.groovy:190)
at org.apache.groovy.parser.antlr4.ParserNegativeSyntaxTest.closed
paren groups before a later syntax error are not missing
parens(ParserNegativeSyntaxTest.groovy:3945)
```
</details>
<details><summary><strong>ParserNegativeSyntaxTest > type pattern in case
label after a record declaration()</strong> (:test in <a
href="https://github.com/apache/groovy/actions/runs/42251469590/job/128007377936?pr=3243";>Build
and test / lts (17, macos-latest)</a>)</summary>
```
org.opentest4j.AssertionFailedError: expected parse to fail
at org.junit.jupiter.api.Assertions.fail(Assertions.java:142)
at
org.apache.groovy.parser.antlr4.TestUtils.compileMessage(TestUtils.groovy:130)
at
org.apache.groovy.parser.antlr4.TestUtils.expectParseError(TestUtils.groovy:190)
at org.apache.groovy.parser.antlr4.ParserNegativeSyntaxTest.type
pattern in case label after a record
declaration(ParserNegativeSyntaxTest.groovy:3927)
```
</details>
### Rerun Controls
> [!NOTE]
> Checks are currently running using the configuration below.
Select tests to mute in this pull request:
🔲 ParserNegativeSyntaxTest > closed paren groups before a later syntax error
are not missing parens\(\) <!
> for await names its source variable with a JVM-wide counter, so class files
> depend on compile order
> ---------------------------------------------------------------------------------------------------
>
> Key: GROOVY-12712
> URL: https://issues.apache.org/jira/browse/GROOVY-12712
> Project: Groovy
> Issue Type: Bug
> Components: parser-antlr4
> Affects Versions: 6.0.0
> Environment: Groovy 6.0.0 binary distribution and master 7379c5720d;
> BellSoft JDK 21.0.12; macOS 15 arm64
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> Since 6.0.0 the parser desugars a {{for await}} loop into a block that
> declares the iterable in a variable named {{$__forAwaitSource_<n>}}
> ({{AsyncTransformHelper.wrapForAwaitLoop}}, called from
> {{AstBuilder.visitForStmtAlt}}). The number comes from a {{static
> AtomicLong}} shared by every compilation in the JVM, not from the source
> unit, so the same file compiles to different class bytes depending on what
> was compiled before it in the same {{groovyc}}, build daemon or IDE session
> (the name reaches the local variable table), and two parses of one file in
> one JVM give two different ASTs.
> Reproducer (6.0.0, JDK 21):
> {code:groovy}
> // Beta.groovy
> class Beta {
> static List<String> names() {
> def gen = async { for (String s in ['a', 'b']) { yield return s } }
> List<String> seen = []
> for await (n in gen) { seen << (n as String) }
> seen
> }
> }
> {code}
> {{Alpha.groovy}} is any other class with one {{for await}} loop.
> {noformat}
> $ groovyc -d one Beta.groovy && javap -p -l -cp one Beta | grep -o
> '\$__forAwaitSource_[0-9]*' | sort -u
> $__forAwaitSource_1
> $ groovyc -d two Alpha.groovy Beta.groovy && javap -p -l -cp two Beta | grep
> -o '\$__forAwaitSource_[0-9]*' | sort -u
> $__forAwaitSource_2
> $ cmp one/Beta.class two/Beta.class
> one/Beta.class two/Beta.class differ: char 1743, line 9
> {noformat}
> Consequences: non-reproducible builds; build caches and incremental compilers
> keyed on outputs see a change that is not in the source; and tools that
> compare the CONVERSION-phase AST of a file with a re-parse of it (a formatter
> checking that it preserved the AST) report a difference for every file with a
> {{for await}} loop. The other names generated for {{async}} and {{yield
> return}} were stable across parses.
> Suggested fix: number the loops per source unit in {{AstBuilder}} and pass
> the number to {{wrapForAwaitLoop}}, so the name depends on the source alone.
> Pull request to follow.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
