codeconsole commented on PR #3113: URL: https://github.com/apache/groovy/pull/3113#issuecomment-6717049253
@daniellansun Merged current master (492ae79db4) for a fresh run of the Windows cell. On the helper: this PR and #3133 each add a private `isClosureCoercibleToSAM` to `StaticTypeCheckingVisitor`, so whichever lands second would not compile next to the other. The land order is #3113 → #3126 → #3133: - Once this PR is in, I'll merge master into #3126 and replace this PR's copy with the `StaticTypeCheckingSupport` one. The Closure and SAM guards that the assignment and return callers rely on move into that helper. - Once #3126 is in, #3133 does the same. I checked that end state on a local merge of the three with one shared helper: `CoercionSTCTest`, `ClosuresSTCTest`, `LambdaTest`, `CoercionStaticCompileTests` and `ReturnConversionConsistencyTest` pass. The Support rule is more lenient (it accepts a raw Closure, `Closure<Object>`, an unresolved `R`, and GString for String), and every negative case of this PR and #3133 is still an error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
