[
https://issues.apache.org/jira/browse/GROOVY-12657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18137402#comment-18137402
]
ASF GitHub Bot commented on GROOVY-12657:
-----------------------------------------
codecov-commenter commented on PR #3178:
URL: https://github.com/apache/groovy/pull/3178#issuecomment-6610131364
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3178?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.1586%. Comparing base
([`0941dba`](https://app.codecov.io/gh/apache/groovy/commit/0941dbacf496a1667c27681c6fe76deee59bfb57?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`19c4be7`](https://app.codecov.io/gh/apache/groovy/commit/19c4be7134eb77403c7fc79a16bb88bb889f66ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/3178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #3178 +/- ##
==================================================
+ Coverage 74.1533% 74.1586% +0.0053%
- Complexity 43751 43754 +3
==================================================
Files 1692 1692
Lines 149516 149516
Branches 28366 28366
==================================================
+ Hits 110871 110879 +8
+ Misses 28448 28442 -6
+ Partials 10197 10195 -2
```
[see 11 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/3178/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> MethodReferenceTest bytecode test fails with groovy.target.closure.pack=true
> ----------------------------------------------------------------------------
>
> Key: GROOVY-12657
> URL: https://issues.apache.org/jira/browse/GROOVY-12657
> Project: Groovy
> Issue Type: Test
> Affects Versions: 7.0.0-alpha-1
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> {code}
> ./gradlew :test -Pgroovy.target.closure.pack=true --tests
> 'groovy.transform.stc.MethodReferenceTest*'
> {code}
> *Actual:*
> {{MethodReferenceTest$NativeMethodReferenceBytecodeTest.testPrivateConstructorOfNestedClassIsCalledDirectlyFromClosureOrLambda}}
> fails with "AssertionError: method ctorRef$doCall$0 not found".
> *Expected:* the test passes with and without the flag.
> The test looks up the generated classes {{C$_inClosure_closure1}} and
> {{C$_inLambda_lambda2}} by name. With closure packing on, the closure body is
> hoisted into {{C}} and the lambda class becomes {{C$_inLambda_lambda1}}. The
> generated code is correct (the packed helper still calls the private Box
> constructor with INVOKESPECIAL). The {{@PackedClosures}} javadoc lists
> per-literal class names as a known difference, so the test's assumption is
> what is wrong.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
