codeconsole commented on PR #3147: URL: https://github.com/apache/groovy/pull/3147#issuecomment-6773200295
@daniellansun On the land order: I answered this on #3137 (https://github.com/apache/groovy/pull/3137#issuecomment-6717091856). In short, @paulk-asert's preference on #3169 is path (1) for 6.0.x regardless: keep the run-time behaviour and have type checking report the access. That is #3137 and then this PR, which is stacked on it. So the order I'd suggest is #3137, then #3147, both on master for cherry-picking to GROOVY_6_0_X. If path (2) is taken for Groovy 7, the rule is narrowed or dropped on master then, as Paul describes on #3169. The run of these shapes against #3169 is in https://github.com/apache/groovy/pull/3137#issuecomment-6608403166: three of them still fail at run time under #3169 (a receiver that is not an instance of the calling class, a write through `super` in a non-static inner subclass, and an enum constant body), so those rejections would stay under (2) as well. The `E.this` compile error for an enum constant body is independent of the direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
