[
https://issues.apache.org/jira/browse/GROOVY-12724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18143782#comment-18143782
]
ASF GitHub Bot commented on GROOVY-12724:
-----------------------------------------
testlens-app[bot] commented on PR #3259:
URL: https://github.com/apache/groovy/pull/3259#issuecomment-6824312019
## 🚨 TestLens detected 2 failed tests 🚨
### Test Summary
> [!TIP]
> Inspect all details with the [TestLens
CLI](https://testlens.app/docs/features/cli): `testlens pr 3259`
#### [Build and test / lts \(17, windows-latest,
1\)](https://github.com/apache/groovy/actions/runs/43220506987/job/131190522686?pr=3259)
> :test
| Test | Runs |
|---|---|
| GenericsJavaCompatibilityTest >
testNegativeParametricTypeForNonGenericClass\(\) | ❌ |
| GenericsJavaCompatibilityTest > testNegativePrimitiveTypeArgument\(\) | ❌ |
🏷️ Commit: 12102d7a81b6c6c14ffe6f8039922eae8e0bfd89
▶️ Tests: 12383 executed
🟡 Checks: 2/23 completed
### Test Failures
<details><summary><strong>GenericsJavaCompatibilityTest >
testNegativeParametricTypeForNonGenericClass()</strong> (:test in <a
href="https://github.com/apache/groovy/actions/runs/43220506987/job/131190522686?pr=3259";>Build
and test / lts (17, windows-latest, 1)</a>)</summary>
```
java.lang.AssertionError: Closure
gls.generics.GenericsJavaCompatibilityTest$_assertNegativeCompile_closure14@7050e135
should have failed with an exception of type
org.codehaus.groovy.control.CompilationFailedException
at groovy.test.GroovyAssert.fail(GroovyAssert.java:121)
at groovy.test.GroovyAssert.shouldFail(GroovyAssert.java:252)
at
gls.generics.GenericsJavaCompatibilityTest.assertNegativeCompile(GenericsJavaCompatibilityTest.groovy:5774)
at
gls.generics.GenericsJavaCompatibilityTest.testNegativeParametricTypeForNonGenericClass(GenericsJavaCompatibilityTest.groovy:907)
```
</details>
<details><summary><strong>GenericsJavaCompatibilityTest >
testNegativePrimitiveTypeArgument()</strong> (:test in <a
href="https://github.com/apache/groovy/actions/runs/43220506987/job/131190522686?pr=3259";>Build
and test / lts (17, windows-latest, 1)</a>)</summary>
```
java.lang.AssertionError: Closure
gls.generics.GenericsJavaCompatibilityTest$_assertNegativeCompile_closure14@767c69d4
should have failed with an exception of type
org.codehaus.groovy.control.CompilationFailedException
at groovy.test.GroovyAssert.fail(GroovyAssert.java:121)
at groovy.test.GroovyAssert.shouldFail(GroovyAssert.java:252)
at
gls.generics.GenericsJavaCompatibilityTest.assertNegativeCompile(GenericsJavaCompatibilityTest.groovy:5774)
at
gls.generics.GenericsJavaCompatibilityTest.testNegativePrimitiveTypeArgument(GenericsJavaCompatibilityTest.groovy:3921)
```
</details>
### Rerun Controls
> [!NOTE]
> Checks are currently running using the configuration below.
Select tests to mute in this pull request:
🔲 GenericsJavaCompatibilityTest >
testNegativeParametricTypeForNonGenericClass\(\) <!
> GINQ: support static compilation and a fluent query API
> -------------------------------------------------------
>
> Key: GROOVY-12724
> URL: https://issues.apache.org/jira/browse/GROOVY-12724
> Project: Groovy
> Issue Type: Improvement
> Components: GINQ
> Reporter: Daniel Sun
> Assignee: Daniel Sun
> Priority: Major
>
> Under @CompileStatic / @TypeChecked, GQ, GQL, and @GQ currently rely on
> dynamic lowering. This improvement makes those entry points usable from a
> statically checked scope while keeping the SQL-like syntax lowered to the
> in-memory collection runtime.
> h3. Goals
> * Allow GQ / GQL / @GQ from @CompileStatic and @TypeChecked without forcing
> the lowered tree through static checking at the expression site.
> * Defer pipeline construction with LazyQueryable until a terminal read
> (toList, count, etc.), copying locals at the expression site (same binding as
> dynamic GQ).
> * Add Ginq.from(...) as a deferred, generic fluent chain on the same runtime,
> with @ClosureParams so where/select/join/aggregate closures can infer element
> types where inference is sound.
> * Preserve default lazy/deferred evaluation and dynamic GQ behavior for map
> rows and other intentionally dynamic cases.
> h3. Non-goals / known limits
> * Stored untyped Closure variables still need a SAM target type for parameter
> inference (same as Java/C#).
> * Raw Query parameters/fields cannot recover a safe element type.
> * Names bound by from inside GQ / GQL / @GQ stay dynamic by design; callers
> that need checked element types use Ginq.from.
> h3. Related work
> GitHub PR: https://github.com/apache/groovy/pull/3259
> Stacked on GEP-26 SQL window work (PR #3167 / gep26-sql-window).
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
