[ 
https://issues.apache.org/jira/browse/GROOVY-10498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18143977#comment-18143977
 ] 

ASF GitHub Bot commented on GROOVY-10498:
-----------------------------------------

qownz opened a new pull request, #3295:
URL: https://github.com/apache/groovy/pull/3295

   Fixes [GROOVY-10498](https://issues.apache.org/jira/browse/GROOVY-10498).
   
   The generated `Map` variant re-applied the default of a positional parameter 
with the elvis operator, so an explicitly supplied `0`, `0.0`, `false` or `""` 
was replaced by the default. The argument is now passed through; a default 
applies only when the argument is omitted, as for named arguments 
(GROOVY-10497).
   
   Regression test: 
`NamedVariantTransformTest.testFalsyPositionalArgumentOverridesDefaultValue`, 
which fails on master with `Color(r:1, g:2, b:3) 4.5`. `:test --tests 
'org.codehaus.groovy.transform.*'` is green (1334 passed).
   




> NamedVariant: default value overrides supplied value if it's falsy 
> (positional parameter)
> -----------------------------------------------------------------------------------------
>
>                 Key: GROOVY-10498
>                 URL: https://issues.apache.org/jira/browse/GROOVY-10498
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 3.0.10, 4.0.0
>            Reporter: Eric Milles
>            Priority: Major
>              Labels: named-parameters
>
> Consider the following:
> {code:groovy}
> import groovy.transform.*
> @ToString(includeNames=true)
> class Color {
>   int r, g, b
> }
> @NamedVariant
> String m(@NamedDelegate Color color, Number alpha=4.5) {
>   return [color, alpha].join(' ')
> }
> print m(r:1, g:2, b:3, 0.0) // "Color(r:1, g:2, b:3) 4.5"!
> {code}



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to