paulk-asert commented on PR #3298: URL: https://github.com/apache/groovy/pull/3298#issuecomment-6887515341
Thanks Daniel! Both nits are in 3068e71492, plus one more from the same family: `Awaitable.first` with sources failing on one shared instance put a `CompletionException` wrapping that instance into its own suppressed list once suppressed exceptions started moving to the cause. `addSuppressedOnce` now compares after peeling JDK wrappers (without moving anything), against both the primary and its cause, which covers your timeout case too. `firstAsync` stores failures unwrapped, and a pending `GroovyPromise.get()` now reads a failure via `join()` like the completed fast path, since `CompletableFuture.get()` drops a `CompletionException`'s suppressed exceptions (that made the outcome timing-dependent). The interrupt test uses your spin-until-interrupted form and asserts the interrupt was actually seen. I'll merge once CI is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
