[ 
https://issues.apache.org/jira/browse/GROOVY-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18146033#comment-18146033
 ] 

ASF GitHub Bot commented on GROOVY-12785:
-----------------------------------------

codecov-commenter commented on PR #3310:
URL: https://github.com/apache/groovy/pull/3310#issuecomment-6939117709

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3310?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :x: Patch coverage is `94.44444%` with `2 lines` in your changes missing 
coverage. Please review.
   :white_check_mark: Project coverage is 74.5958%. Comparing base 
([`88b30dd`](https://app.codecov.io/gh/apache/groovy/commit/88b30ddf6679cfa0e38b416fffd7677d764138ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`69da7d9`](https://app.codecov.io/gh/apache/groovy/commit/69da7d92477e650119b8f7e9b419e0c8d147d9e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/3310?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...groovy/lsp/internal/feature/CompletionService.java](https://app.codecov.io/gh/apache/groovy/pull/3310?src=pr&el=tree&filepath=subprojects%2Fgroovy-lsp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Flsp%2Finternal%2Ffeature%2FCompletionService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWxzcC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2xzcC9pbnRlcm5hbC9mZWF0dXJlL0NvbXBsZXRpb25TZXJ2aWNlLmphdmE=)
 | 94.4444% | [0 Missing and 2 partials :warning: 
](https://app.codecov.io/gh/apache/groovy/pull/3310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/3310/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/3310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #3310        +/-   ##
   ==================================================
   + Coverage     74.5879%   74.5958%   +0.0079%     
   - Complexity      45361      45382        +21     
   ==================================================
     Files            1707       1707                
     Lines          153183     153219        +36     
     Branches        29442      29454        +12     
   ==================================================
   + Hits           114256     114295        +39     
   + Misses          28418      28417         -1     
   + Partials        10509      10507         -2     
   ```
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/3310?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[...groovy/lsp/internal/feature/CompletionService.java](https://app.codecov.io/gh/apache/groovy/pull/3310?src=pr&el=tree&filepath=subprojects%2Fgroovy-lsp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Flsp%2Finternal%2Ffeature%2FCompletionService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWxzcC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2xzcC9pbnRlcm5hbC9mZWF0dXJlL0NvbXBsZXRpb25TZXJ2aWNlLmphdmE=)
 | `88.5204% <94.4444%> (+0.5991%)` | :arrow_up: |
   
   ... and [11 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/3310/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> Completion of an unqualified name omits the implicit receiver's methods, such 
> as println
> ----------------------------------------------------------------------------------------
>
>                 Key: GROOVY-12785
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12785
>             Project: Groovy
>          Issue Type: Bug
>            Reporter: Scott Murphy Heiberg
>            Priority: Major
>
> Since GROOVY-12448 groovysh and the Groovy Console complete through the 
> in-process language engine (groovy-lsp). For an unqualified name it offers 
> keywords, snippets, locals, the members the file's own classes declare, and 
> workspace types, but nothing the implicit receiver inherits or gains from 
> extension methods.
> In groovysh, {{printl}} + Tab no longer completes to {{println}}, and 
> {{prin}}, {{sle}} and {{sprin}} offer nothing, although Groovy 6.0.0's 
> groovysh completes all of them. {{this.printl}} does offer {{println}}.
> An unqualified name should also offer the members of the enclosing class's 
> supertypes (for a script, {{Script}}'s {{print}}, {{println}} and {{printf}}) 
> and the extension methods that apply to it ({{sleep}}, {{sprintf}}). Inside a 
> static method the class's instance members do not apply, while the extension 
> methods still do.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to