Github user eginez commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/16#discussion_r30418833
--- Diff: src/test/org/codehaus/groovy/runtime/URLGetBytesTest.groovy ---
@@ -0,0 +1,114 @@
+/*
+ * Copyright 2003-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.codehaus.groovy.runtime
+
+/**
+ * Tests for {@link DefaultGroovyMethods} URL.getBytes() methods.
+ *
+ */
+class URLGetBytesTest extends GroovyTestCase {
+ void testGetBytesFromURLWithParameters() {
+ def url = new URL('http','groovy.codehaus.org',80, '/', new
URLStreamHandler() {
+ @Override
+ protected URLConnection openConnection(URL u) {
+ new DummyURLConnection(new
URL('http://groovy.codehaus.org'))
+ }
+
+ })
+
+ assert url.bytes == 'Groovy'.bytes
+
+ shouldFail(SocketTimeoutException) {
+ url.getBytes(readTimeout:5)
+ }
+
+ shouldFail(SocketTimeoutException) {
+ url.getText(connectTimeout:5)
+ }
+
+ shouldFail(RuntimeException) {
+ url.getBytes(allowUserInteraction:true)
+ }
+
+ assert url.getBytes(useCaches:true) == 'Groovy cached'.bytes
+
+ assert url.getBytes(requestProperties:[a:'b']) == 'Groovy
a:b'.bytes
+
+ assert url.getBytes(useCaches:true, requestProperties:[a:'b']) ==
'Groovy cached a:b'.bytes
+
+ assert url.getBytes() == url.getBytes()
--- End diff --
oops line shouldn't be there, fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
