[
https://issues.apache.org/jira/browse/GROOVY-7425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545671#comment-14545671
]
ASF GitHub Bot commented on GROOVY-7425:
----------------------------------------
Github user eginez commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/16#discussion_r30418833
--- Diff: src/test/org/codehaus/groovy/runtime/URLGetBytesTest.groovy ---
@@ -0,0 +1,114 @@
+/*
+ * Copyright 2003-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.codehaus.groovy.runtime
+
+/**
+ * Tests for {@link DefaultGroovyMethods} URL.getBytes() methods.
+ *
+ */
+class URLGetBytesTest extends GroovyTestCase {
+ void testGetBytesFromURLWithParameters() {
+ def url = new URL('http','groovy.codehaus.org',80, '/', new
URLStreamHandler() {
+ @Override
+ protected URLConnection openConnection(URL u) {
+ new DummyURLConnection(new
URL('http://groovy.codehaus.org'))
+ }
+
+ })
+
+ assert url.bytes == 'Groovy'.bytes
+
+ shouldFail(SocketTimeoutException) {
+ url.getBytes(readTimeout:5)
+ }
+
+ shouldFail(SocketTimeoutException) {
+ url.getText(connectTimeout:5)
+ }
+
+ shouldFail(RuntimeException) {
+ url.getBytes(allowUserInteraction:true)
+ }
+
+ assert url.getBytes(useCaches:true) == 'Groovy cached'.bytes
+
+ assert url.getBytes(requestProperties:[a:'b']) == 'Groovy
a:b'.bytes
+
+ assert url.getBytes(useCaches:true, requestProperties:[a:'b']) ==
'Groovy cached a:b'.bytes
+
+ assert url.getBytes() == url.getBytes()
--- End diff --
oops line shouldn't be there, fixed
> Add 'getBytes(Map parameters)' method to the URL class
> ------------------------------------------------------
>
> Key: GROOVY-7425
> URL: https://issues.apache.org/jira/browse/GROOVY-7425
> Project: Groovy
> Issue Type: Improvement
> Components: groovy-jdk
> Reporter: Michael Fairfield
> Assignee: Guillaume Laforge
>
> The URL class has a {{[getText(Map
> parameters)|http://docs.groovy-lang.org/latest/html/groovy-jdk/java/net/URL.html#getText(java.util.Map)]}}
> method but no {{getBytes(Map parameters)}}.
> So currently we can't set the user agent and other parameters when
> downloading files with the {{getBytes}} method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
