[ https://issues.apache.org/jira/browse/GROOVY-7461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578843#comment-14578843 ]
ASF GitHub Bot commented on GROOVY-7461: ---------------------------------------- GitHub user keeganwitt opened a pull request: https://github.com/apache/incubator-groovy/pull/36 fix for GROOVY-7461 I didn't see any unit tests for this method. Feel free to point them out if I've missed it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/keeganwitt/incubator-groovy master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 ---- commit cb623e5038f1478933afe35645a75f93ed1322a9 Author: Keegan Witt <keeganw...@gmail.com> Date: 2015-06-09T12:53:07Z fix for GROOVY-7461 ---- > Groovy doesn't write BOM if UTF-16 alias is used > ------------------------------------------------ > > Key: GROOVY-7461 > URL: https://issues.apache.org/jira/browse/GROOVY-7461 > Project: Groovy > Issue Type: Bug > Components: groovy-jdk > Reporter: Keegan Witt > Assignee: Guillaume Laforge > > The {{newWriter(charset, append)}}, {{File.append(text, charset)}}, > {{File.write(text, charset)}} methods all don't write the UTF-16 BOM if an > alias for UTF-16 is used. For example, if the "UTF_16LE" alias for > "UTF-16LE" is used, no BOM is written even though a BOM is written for the > canonical name. This is because {{writeUTF16BomIfRequired(charset, stream)}} > only checks for the canonical name, and not any aliases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)