[ 
https://issues.apache.org/jira/browse/GROOVY-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624615#comment-14624615
 ] 

ASF GitHub Bot commented on GROOVY-7486:
----------------------------------------

Github user keeganwitt commented on a diff in the pull request:

    https://github.com/apache/incubator-groovy/pull/59#discussion_r34459936
  
    --- Diff: src/test/groovy/tree/NavigationTest.groovy ---
    @@ -57,11 +65,25 @@ class NavigationTest extends GroovyTestCase {
                 }
                 b5()
             }
    -        
             assert root != null
    -        
    -        println(root)
    -        
             return root
         }
    +
    +    private static createTreeFromXmlParser() {
    +        def xml = '''
    +        <root>
    +          <parent1>
    +            <childa/>
    +            <childb/>
    +          </parent1>
    +          <parent2>
    +            <childa/>
    --- End diff --
    
    I think it'd improve this test to have all nodes uniquely named.


> In groovy.util.Node.depthFirst please Provide a way to Specify In-order, 
> pre-order, post-order Ordering
> -------------------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-7486
>                 URL: https://issues.apache.org/jira/browse/GROOVY-7486
>             Project: Groovy
>          Issue Type: Improvement
>          Components: groovy-jdk
>            Reporter: Suminda Dharmasena
>            Priority: Minor
>
> Please provide a way to specify the ordering in depth 1st traversal.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to