GitHub user tkruse opened a pull request:
https://github.com/apache/incubator-groovy/pull/112
GROOVY-7563: Make InvokerHelper output self-consistent
Changes the internal API of the formatting methods in InvokerHelper and
also the output in some cases when using verbose or safe arguments.
This PR contains currently controversial changes to the formatting methods
in InvokerHelper that could break client code.
Further analysis and discussion required.
This currently contains the commits from #96 (until that one is merged).
(This supercedes #111, which had the wrong JIRA number in commit messages)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tkruse/incubator-groovy groovy-7563
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-groovy/pull/112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #112
----
commit 7348234fc682e8bdc63d1d7e3bd0e0581d9307a1
Author: Thibault Kruse <thibault.kr...@gmx.de>
Date: 2015-08-21T14:02:32Z
Refactor: Code style - if block
commit 8787aea597cef9c47dc0b3a619cc44d9da34a5ac
Author: Thibault Kruse <thibault.kr...@gmx.de>
Date: 2015-08-21T14:06:46Z
InvokerHelper: Refactor: Better StringBuffer pre-allocation
commit f898b92f32a14e03bff6f17ac0afbe163cf59a72
Author: Thibault Kruse <thibault.kr...@gmx.de>
Date: 2015-08-21T14:07:38Z
InvokerHelper: Refactor: Rename private method
commit 677cccf903e154b2d16be55c2df0d52a2a48a403
Author: Thibault Kruse <thibault.kr...@gmx.de>
Date: 2015-08-21T14:11:52Z
InvokerHelper: Refactor: Implement Array formatting like Collection
formatting
commit 4571a7fa8d5be7ab16ccca7910a70287a58efee9
Author: Thibault Kruse <thibault.kr...@gmx.de>
Date: 2015-09-01T22:15:55Z
InvokerHelper: Refactor: invoke specific methods.
commit a6826f1d1d00607ee9259b8ba81dbd9e3217e78a
Author: Thibault Kruse <thibault.kr...@gmx.de>
Date: 2015-09-01T22:17:40Z
InvokerHelper: Refactor: Avoid unnecessary array transformation for Object[]
commit fc41a62c9351f0714db950df7b5ad043f5b19ea0
Author: Thibault Kruse <thibault.kr...@gmx.de>
Date: 2015-09-01T22:17:43Z
InvokerHelper: Refactor: Remove redundant if cases, format method has them
commit 9982da56abcb608be9ff6e61a6562d43a8da4599
Author: Thibault Kruse <thibault.kr...@gmx.de>
Date: 2015-09-01T22:25:13Z
InvokerHelper: Regression tests for formatting
commit e3ba0a24ac0b42c92525df286ab32b56a3dfbaaf
Author: Thibault Kruse <thibault.kr...@gmx.de>
Date: 2015-09-01T22:17:43Z
GROOVY-5763: InvokerHelper: Remove redundant if cases, format method has
them
commit 0b493fb6c8ab70d901053879d4d5122961f576a8
Author: Thibault Kruse <thibault.kr...@gmx.de>
Date: 2015-08-21T14:23:10Z
GROOVY-7563: InvokerHelper: Provide safe formatting consistently (not just
for lists)
commit 70b4e2cf0620a20dab53e8bbe107db4fd4f27e4f
Author: Thibault Kruse <thibault.kr...@gmx.de>
Date: 2015-08-21T14:23:37Z
GROOVY-7563: InvokerHelper: Map formatting safe and self-detecting also for
keys
commit 4f17c6bf9d7af37e859e05afb766b85b9a92603a
Author: Thibault Kruse <thibault.kr...@gmx.de>
Date: 2015-08-21T16:28:00Z
GROOVY-7563: InvokerHelper: Safe formatting of ranges, rethrow
RuntimeException without wrap.
commit d158abdb73a6bcec0bdcbd7c8dc925c1c0fa53be
Author: Thibault Kruse <thibault.kr...@gmx.de>
Date: 2015-09-01T22:37:51Z
GROOVY-5763: InvokerHelper: Additional regression tests for formatting
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
