Github user PascalSchumacher commented on a diff in the pull request:

    https://github.com/apache/incubator-groovy/pull/176#discussion_r44223209
  
    --- Diff: 
subprojects/groovy-nio/src/main/java/org/codehaus/groovy/runtime/NioGroovyMethods.java
 ---
    @@ -1540,12 +1709,33 @@ public static BufferedWriter newWriter(Path self, 
String charset) throws IOExcep
          * @since 2.3.0
          */
         public static <T> T withWriterAppend(Path self, String charset, 
@ClosureParams(value = SimpleType.class, options = "java.io.Writer") Closure<T> 
closure) throws IOException {
    -        return IOGroovyMethods.withWriter(newWriter(self, charset, true), 
closure);
    +        return withWriterAppend(self, charset, false, closure);
    +    }
    +
    +    /**
    +     * Create a new BufferedWriter which will append to this
    +     * file.  The writer is passed to the closure and will be closed before
    +     * this method returns.  The writer will use the given charset 
encoding.
    +     * If the given charset is "UTF-16BE" or "UTF-16LE" (or an equivalent 
alias),
    +     * <code>writeBom</code> is <code>true</code>, and the file doesn't 
already exist,
    +     * the requisite byte order mark is written to the stream when the 
writer is created.
    +     *
    +     * @param self    a Path
    +     * @param charset the charset used
    +     * @param writeBom whether to write the BOM
    +     * @param closure a closure
    +     * @return the value returned by the closure
    +     * @throws java.io.IOException if an IOException occurs.
    +     * @since 2.3.0
    --- End diff --
    
    should be 2.5.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to