pjfanning commented on code in PR #1335: URL: https://github.com/apache/hamilton/pull/1335#discussion_r2108681205
########## LICENSE: ########## @@ -1,22 +1,15 @@ Copyright (c) 2019-2022 Stitch Fix Copyright (c) 2023-2025 DAGWorks Inc. -All rights reserved. +Copyright (c) 2025-present Apache Software Foundation Review Comment: Please use the standard Apache license without the old copyrights (or the new copyright line) - they can move to the NOTICE file. You already have the Apache copyright there. https://www.apache.org/licenses/LICENSE-2.0.txt TBH I would prefer if the old copyrights were removed altogther. You have signed a SGA donating the code to the ASF. If you absolutely want to retain the old copyrights, I think we might need legal advice on this. ########## DISCLAIMER: ########## @@ -0,0 +1,10 @@ +Apache Hamilton (incubating) is an effort undergoing incubation at the Apache +Software Foundation (ASF), sponsored by the Apache Incubator PMC. + +Incubation is required of all newly accepted projects until a further review +indicates that the infrastructure, communications, and decision making process +have stabilized in a manner consistent with other successful ASF projects. + +While incubation status is not necessarily a reflection of the completeness +or stability of the code, it does indicate that the project has yet to be +fully endorsed by the ASF. Review Comment: can you add a new line at eof? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
