jernejfrank commented on PR #1342:
URL: https://github.com/apache/hamilton/pull/1342#issuecomment-2973558317
> > I don't have access to CircleCI to see the settings there (I assume the
config with jobs and worklof is only part of it, since there's no mention of OS
inside), would be good to let me know if anything else needs to be configured
for the github actions workflow.
>
> @jernejfrank you can see everything in the .circleci yaml and what it
references. It's similar to github workflows, but we have more flexibility on
when a workflow is triggered with the github way. So shouldn't be hard to
replicate.
Ah ok, then all is migrated! I thought there might be something more since
the .circleci yaml doesn't mention anything about OS to test on, etc..
Also added this to the notes of the pr:
- some test (mostly plugins) were running only on specific python versions
and run now on all supported python versions of the plugin package:
- Ray, Dask, PySpark 3.9-3.12
- pre-commit 3.8-3.12 (sometimes important to spot things like needing
`from __future__ import annotations`)
- pandas, polars, narwhals 3.8-3.12
Will be fixing broken tests, but may take a while!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
