skrawcz commented on issue #1336:
URL: https://github.com/apache/hamilton/issues/1336#issuecomment-3125300613
> I think we also need a plan on what appears in the source release. It
makes releases easier if you don't put everything from the git repo in the
source release. I'm thinking specifically about files that are related just to
the web site could be excluded from the source release - meaning that we won't
have binary files like pngs in the release and it means the omitted files don't
necessarily need source headers. You must have enough in the source release to
allow users to build Hamilton from the source release.
@pjfanning how familiar are you with how python packages are built?
For example for sf-hamilton it's dictated by:
- https://github.com/apache/hamilton/blob/main/MANIFEST.in
- https://github.com/apache/hamilton/blob/main/pyproject.toml#L251-L256
which means it's *.py files under hamilton/
This then gets made into https://pypi.org/project/sf-hamilton/#files a
source and a "built" distribution -- python is interpreted and at least for
hamilton there is no compilation that happens anywhere... i.e. when you install
the package, you see all the source python files.
So this does not include all the files in the repository which I think fits
what you're asking for, right? We can push that .tar.gz file to where it needs
to for apache process is how I think I understand it, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
