skrawcz commented on code in PR #1376: URL: https://github.com/apache/hamilton/pull/1376#discussion_r2328758515
########## hamilton/base.py: ########## @@ -20,21 +20,22 @@ It cannot import hamilton.graph, or hamilton.driver. """ +from __future__ import annotations + import abc import collections import logging -from typing import Any, Dict, List, Optional, Tuple, Type, Union - -import numpy as np -import pandas as pd -from pandas.core.indexes import extension as pd_extension +from typing import TYPE_CHECKING, Any, Dict, List, Optional, Tuple, Type, Union +from hamilton import htypes from hamilton.lifecycle import api as lifecycle_api -try: - from . import htypes, node -except ImportError: - import node +if TYPE_CHECKING: Review Comment: I.e. this is for hamilton-core to work... ########## hamilton/base.py: ########## @@ -20,21 +20,22 @@ It cannot import hamilton.graph, or hamilton.driver. """ +from __future__ import annotations + import abc import collections import logging -from typing import Any, Dict, List, Optional, Tuple, Type, Union - -import numpy as np -import pandas as pd -from pandas.core.indexes import extension as pd_extension +from typing import TYPE_CHECKING, Any, Dict, List, Optional, Tuple, Type, Union +from hamilton import htypes from hamilton.lifecycle import api as lifecycle_api -try: - from . import htypes, node -except ImportError: - import node +if TYPE_CHECKING: Review Comment: E.g. this is for hamilton-core to work... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
