Phrogz opened a new issue, #1384:
URL: https://github.com/apache/hamilton/issues/1384

   The [documentation for `@resolve` 
decorator](https://hamilton.apache.org/reference/decorators/resolve/) includes 
this example code:
   
   ```python
   @parameterize_values(
       series_sum_1={"s1": "series_1", "s2": "series_2"},
       series_sum_2={"s1": "series_3", "s2": "series_4"},
   )
   def summation(df: pd.DataFrame, s1: str, s2: str) -> pd.Series:
       return df[s1] + df[s2]
   ```
   
   However, that is incorrect usage of the `@parameterize_values` decorator. 
That is the usage for `@parameterize` decorator.
   
   ## Steps to replicate behavior
   1. Go to [the docs 
page](https://hamilton.apache.org/reference/decorators/resolve/)
      * Alternatively, view [this snapshot of the source 
content](https://github.com/apache/hamilton/blob/c838df2f46a4105ee413ad233d469a2b445afbb2/hamilton/function_modifiers/delayed.py#L80).
   
   
   # Additional context
   
   This example was changed from `@parameterize` to `@parametrize_values` in 
commit 67f7918 17 months ago. I'm unsure if it was valid then, but I'm fairly 
certain it is not valid now.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to