iprithv opened a new pull request, #1418:
URL: https://github.com/apache/hamilton/pull/1418
--- PR TEMPLATE INSTRUCTIONS (1) ---
Looking to submit a Apache Hamilton Dataflow to the sf-hamilton-contrib
module? If so go the the `Preview` tab and select the appropriate sub-template:
* [sf-hamilton-contrib
template](?expand=1&template=HAMILTON_CONTRIB_PR_TEMPLATE.md)
Else, if not, please remove this block of text.
--- PR TEMPLATE INSTRUCTIONS (2) ---
**fix: remove deprecated pandas CSV reader args (`keep_date_col`, `verbose`,
`delim_whitespace`)**
These pandas arguments are deprecated and generate warnings during the test
suite.
This PR removes them from Hamilton’s `PandasCSVReader` to maintain future
compatibility and keep test output clean.
## Changes
- Removed usage of deprecated pandas CSV parameters:
- `keep_date_col`
- `verbose`
- `delim_whitespace`
- Updated `_get_loading_kwargs()` to avoid passing these keywords.
- Ensures compatibility with newer pandas versions (≥ 2.x).
- Eliminates deprecation warnings observed in
`test_pandas_extensions_end_to_end`.
## How I tested this
- Ran the test suite with pytest
- Confirmed that CSV-related tests pass without warnings
## Notes
- This affects only internal IO adapters and does not modify public APIs.
- Safe backward-compatible cleanup.
## Checklist
- [x] PR has an informative, human-readable title
- [x] Changes limited to a single goal
- [x] Code passes pre-commit and removes old warnings
- [x] No functional behaviour change; only param cleanup
- [x] Any updated helper logic covered by existing tests
- [x] No leftover TODOs or placeholder code
- [x] Documentation not required (internal cleanup)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
