dukbong opened a new pull request, #1827: URL: https://github.com/apache/hertzbeat/pull/1827
## What's changed? <!-- Describe Your PR Here --> #### Description This PR simplifies the code by using Assert methods and changes the location of the `validateParams()` process. By moving this process, `validateParams()` can perform a null check earlier. #### Question In the JmxCollectImpl code, the `getConnectSession()` checks whether `jmxProtocol.getUrl() != null`, which is already validated in `validateParams()`. This redundancy seems unnecessary, but I'm not entirely sure if I'm missing something, so I left the source code unchanged. Do you think this extra check is required? #### Other Work This PR also includes translation work, converting text from Chinese to English. ## Checklist - [ ] I have read the [Contributing Guide](https://hertzbeat.apache.org/docs/community/code_style_and_quality_guide) - [ ] I have written the necessary doc or comment. - [ ] I have added the necessary unit tests and all cases have passed. ## Add or update API - [ ] I have added the necessary [e2e tests](https://github.com/apache/hertzbeat/tree/master/e2e) and all cases have passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
