crossoverJie commented on PR #1850: URL: https://github.com/apache/hertzbeat/pull/1850#issuecomment-2078484023
Could you please add some unit tests for this? You can refer this: https://github.com/apache/hertzbeat/blob/8ffe0dae5c6839ab46cfd3449e643c4101ae614f/collector/src/test/java/org/apache/hertzbeat/collector/collect/nginx/NginxCollectImplTest.java#L75 --- BTW, it is recommended to fill in the content according to the PR template. If the content is empty, it will not be conducive to code review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
