tomsun28 commented on code in PR #1856:
URL: https://github.com/apache/hertzbeat/pull/1856#discussion_r1580988772
##########
collector/src/main/java/org/apache/hertzbeat/collector/collect/ftp/FtpCollectImpl.java:
##########
@@ -41,12 +43,13 @@ public class FtpCollectImpl extends AbstractCollect {
private static final String ANONYMOUS = "anonymous";
private static final String PASSWORD = "password";
+ @Setter
+ @VisibleForTesting
+ private FTPClient ftpClient = new FTPClient();
Review Comment:
hi FTPClient does not seem to be thread-safe. Writing this way will cause
multiple thread collection exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
